[#24936] - [4.0] Start converting actionlogs to new format
- Fixed in Code Base
- 30 Jun 2019
- Medium
- Build: 4.0-dev
- # 24936
- Diff
- roland-d:feature/view-model-actionlogs
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
This will be a conversion of the com_actionlogs component to use the new Joomla 4 structure.
Testing Instructions
Component Action Logs
- Go to Users -> Users Action Log
- Check that the table of actions show
- Check that the search works
- Check that the filtering works
- Check that the Options work
User Editing
- Go to Users -> Manage
- Edit an admin user
- Check that the User Actions Log Options tab shows
- Check that the options are saved
Latest Action Logs Module
- Go to Content -> Administrator Modules
- Check that the Latest Actions module is enabled. If not, enable the module
- Go to Control Panel
- Check that the module shows
Plugins
- Go to System -> Plugins
- Edit the
System - User Actions Logand check that the settings can be saved - Edit the
Action Log - Joomlaand check that the settings can be saved - Edit the
Privacy - Action Logsand check that the settings can be saved
Enable the plugins and check that the functionality still works.
Use Action Logs as usual and make sure it all works as expected.
Expected result
It works as before the changes
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_messages |
franz-wohlkoenig
- | Title |
|
||||||
| Labels |
Added:
?
|
||
| Category | Administration com_messages | ⇒ | Administration com_modules Modules Front End Plugins |
| Category | Administration com_modules Modules Front End Plugins | ⇒ | Administration com_modules Language & Strings Modules Front End Plugins |
| Labels |
Added:
?
|
||
| Category | Administration com_modules Modules Front End Plugins Language & Strings | ⇒ | Administration Language & Strings Modules Front End Plugins |
If you remove this line then the width of the filters will be set correctly
@brianteeman I removed the chosen line and the multi-select line as well. There are no multi-select options on this page.
$model->setState('list.limit', $params->get('count', 5));
This line works fine for me. It is reading the module settings.
I did find something else, the tooltip/popover on the Date column doesn't work. I just don't know why. Anybody any idea?
Before applying the pr the debug is showing me the query for the module with ORDER BY a.id DESC LIMIT 5 After applying the pr it is showing me ORDER BY a.id DESC LIMIT 20
I did find something else, the tooltip/popover on the Date column doesn't work. I just don't know why. Anybody any idea?
Do you mean this
data-original-title="2019-05-19 20:40:44"
If so then we shouldnt be using a tooltip for that as it is not accessible but instead use the method I show in #24899
@brianteeman I will have a look at the query later. As for the tooltip, yes that is what I meant. Currently in J3 when you hover over it, this shows up as a tooltip. I will take a look at your implementation. Thanks.
@brianteeman You were right about the limit, that is fixed now.
As for the tooltip I have implemented what you have done in #24899 This change is now dependent on your PR being merged. However there is one issue I see:
I am hovering on the second row, notice the time showing up above the search field. The same happens for all rows. I would expect it to show up next to the date I am hovering.
administrator/components/com_actionlogs/Libraries/Actionlogplugin.php must be called ActionLogPlugin.php.
ActionLogPlugin.php, not ActionlogPlugin.php.
This needs a test before merging
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-28 19:29:28 |
| Closed_By | ⇒ | roland-d |
Why did you close this?
@brianteeman I accidentally removed the branch. No intention to close it before it is merged :)
| Status | Closed | ⇒ | New |
| Closed_Date | 2019-06-28 19:29:28 | ⇒ | |
| Closed_By | roland-d | ⇒ |
| Status | New | ⇒ | Pending |
@Quy / @richard67 / @brianteeman / @SharkyKZ can one of you fine people please give this a test so we can make this nice and consistent?
will try to tomorrow
@roland-d Maybe you should mention in the testing instructions to remove file libraries/autoload_psr4.php after having applied the changes in this PR, so the file gets rebuilt, otherwise you get a PHP fatal error:
PHP Fatal error: Class 'Joomla\Component\Actionlogs\Administrator\Libraries\ActionLogPlugin' not found in /home/richard/lamp/public_html/joomla-cms-4.0-dev/plugins/actionlog/joomla/joomla.php on line 24
I know this is clear for insiders, but to be sure it should be included in testing instructions.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24936.
I get a PHP notice about undefined variable when using the CSV export buttons, but that does not come from this PR here. It is also there in current 4.0-dev.
Without this PR: PHP Notice: Undefined variable: app in /home/richard/lamp/public_html/joomla-cms-4.0-dev/administrator/components/com_actionlogs/controllers/actionlogs.php on line 122
With this PR: PHP Notice: Undefined variable: app in /home/richard/lamp/public_html/joomla-cms-4.0-dev/administrator/components/com_actionlogs/Controller/ActionlogsController.php on line 122
Everything else seems to be ok, works like before.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24936.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24936.
@richard67 Please test PR #25369 for the export buttons fix.
Sorry a bit late to the party but there are a few mainly codestyle changes I have marked plus
This should be <th scope="row">
| Status | Ready to Commit | ⇒ | Pending |
Remove RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24936.
First of all, thank you all for chipping in.
@richard67 I wasn't aware we had to delete the autoloader file.
@brianteeman I learned something new, I wasn't aware we could use td in thead and tr in tbody :)
@wilsonge All updated.
Always a good day when you learn something new
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-30 07:36:35 |
| Closed_By | ⇒ | wilsonge |
Thanks everyone!
Not sure why but the module count is not working. It isnt getting the param from the module
joomla-cms/administrator/modules/mod_latestactions/helper.php
Line 42 in 8c6ad2a