[#24933] - [4.0] Make login module IDs unique
- Fixed in Code Base
- 18 May 2019
- Medium
- Build: 4.0-dev
- # 24933
- Diff
- SharkyKZ:j4/modLoginIds
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23538 and followup to #24757.
Summary of Changes
Appends module ID to ID attribute to prevent duplicate IDs when multiple login modules are published on one page.
Testing Instructions
Code review.
Or publish multiple login modules and validate HTML.
Expected Result
No validation errors.
Actual Result
Validation errors like:
Error: Duplicate ID modlgn-username.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24933.
| Labels |
Added:
?
|
||
I have tested this item
1. Code review: All instances for duplicate ids and corresponding <label for=... have been corrected by this PR, nothing was forgotten.
2. W3C validator: Without this PR duplicate ID errors, with this PR no such errors.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24933.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24933.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24933.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-18 22:03:26 |
| Closed_By | ⇒ | roland-d |
I have tested this item✅ successfully on 1dc4ebc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24933.