? Success

User tests: Successful: Unsuccessful:

avatar BrainforgeUK
BrainforgeUK
16 May 2019

Pull Request for Issue #19584.

Summary of Changes

Added event onContentValidateData

Testing Instructions

Create a field plugin which implements onContentValidateData function like this...
public function onContentValidateData($form, &$data) {
// Change the data in some way
}

Expected result

The data get's changed.

Actual result

The data get's changed.

Documentation Changes Required

Add documentation for onContentValidateData event.
Add documentation for the existing, but undocumented and now deprecated, onUserBeforeDataValidation event.

avatar BrainforgeUK BrainforgeUK - open - 16 May 2019
avatar BrainforgeUK BrainforgeUK - change - 16 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2019
Category Libraries
avatar BrainforgeUK BrainforgeUK - change - 16 May 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2019
Category Libraries Administration com_installer Language & Strings Libraries
avatar BrainforgeUK
BrainforgeUK - comment - 16 May 2019

Also added com_install change commit for 'Improved extension update error message' by accident. This applies to Joomla issue #22762.
I am struggling with how to create 2 pull requests for separate issues.

Undone the mentioned com_install change.

avatar BrainforgeUK BrainforgeUK - change - 16 May 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2019
Category Libraries Administration com_installer Language & Strings Libraries
avatar BrainforgeUK BrainforgeUK - change - 16 May 2019
Labels Removed: ?
avatar SharkyKZ
SharkyKZ - comment - 16 May 2019

I am struggling with how to create 2 pull requests for separate issues.

Instead of making changes to 4.0-dev branch, create separate branches for each PR.

avatar BrainforgeUK
BrainforgeUK - comment - 3 Jun 2019

Replaced by pull request #25103

avatar BrainforgeUK BrainforgeUK - close - 3 Jun 2019
avatar BrainforgeUK BrainforgeUK - change - 3 Jun 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-06-03 11:06:17
Closed_By BrainforgeUK

Add a Comment

Login with GitHub to post a comment