[#24921] - [4.0] Module edit. Dropdown Save&Close fails when module User Status deactivated
- Fixed in Code Base
- 16 May 2019
- Medium
- Build: 4.0-dev
- # 24921
- Diff
- ReLater:patch-2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules |
I have tested this item
Note: it is also needed for site modules edit if the User Status module is unpublished.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24921.
Note: it is also needed for site modules edit if the User Status module is unpublished.
I'll provide a pr.
We may improve this by also taking off the code from the User Status module as it will not be necessary anymore.
What I meant is that adding it in the edit.php as done here solves the issue for all modules edit, site and admin.
| Labels |
Added:
?
|
||
Yes, my #24921 (comment) was nonsense ;-)
| Title |
|
||||||
We may improve this by also taking off the code from the User Status module as it will not be necessary anymore.
Let's do it in another pr after this one has been merged. There are several modules with line
HTMLHelper::_('bootstrap.framework'); in tmpl/default.php but I'm not sure if we need them for output and not just for edit purposes.
I've added a reminder to my ToDos.
This should probably be added to dropdown button layout.
| Category | Administration com_modules | ⇒ | Layout |
Moved fix to layouts/joomla/toolbar/dropdown.php
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24921.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24921.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24921.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24921.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24921.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-16 18:00:32 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on 67cfd27
Note: it is also needed for site modules edit if the User Status module is unpublished.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24921.