[#24917] - B/C fix - Modules (including core) using the "cache" XML parameter always cached, regardless of that parameter's value
- Closed
- 15 May 2019
- Medium
- Build: staging
- # 24917
Steps to reproduce the issue
Many Joomla core modules (e.g. mod_menu, mod_custom etc.) as well as lots of third-party modules still use "cache" as the de-facto XML parameter to allow for a module to be cached along with the rest of Joomla's rendered content (when Joomla caching is set to "on") or excluded from Joomla's cache overall.
The current check in JModuleHelper::moduleCache() is currently invalid (checks for the newer "owncache" XML parameter twice).
See pull request #24916 for the simple fix.
Expected result
When Joomla's cache is enabled, most core modules with caching set to "no" (usually under the Advanced tab in their parameters) and probably the vast majority of third-party modules are always cached. This should not happen.
Actual result
System information (as much as possible)
Additional comments
| Labels |
Added:
?
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-15 21:06:23 |
| Closed_By | ⇒ | joomla-cms-bot |
| Closed_Date | 2019-05-15 21:06:23 | ⇒ | 2019-05-15 21:06:25 |
| Closed_By | joomla-cms-bot | ⇒ | Quy |
FYI: It is not necessary to open an issue if you have a PR for it.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24917.
The pull request template mentions a reference to the issue ID at the very top. Perhaps you should explicitly mention there that it's not need to also open an issue. ;)
franz-wohlkoenig
- | Title |
|
||||||
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24917