? Pending

User tests: Successful: Unsuccessful:

avatar BrainforgeUK
BrainforgeUK
14 May 2019

Pull Request for Issue #19584 .
Summary of Changes

Added event onContentValidateData
Testing Instructions

Create a field plugin which implements onContentValidateData function like this...
public function onContentValidateData($form, &$data) {
// Change the data in some way
}
Expected result

The data get's changed.
Actual result

The data get's changed.
Documentation Changes Required

Add documentation for onContentValidateData event.
Add documentation for the existing, but undocumented and now deprecated, onUserBeforeDataValidation event.
This event will only get triggered when validate() overridden by a user component model.

avatar BrainforgeUK BrainforgeUK - open - 14 May 2019
avatar BrainforgeUK BrainforgeUK - change - 14 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2019
Category Libraries
avatar BrainforgeUK
BrainforgeUK - comment - 16 May 2019

Superceded.

avatar BrainforgeUK BrainforgeUK - change - 16 May 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-05-16 16:53:02
Closed_By BrainforgeUK
Labels Added: ?
avatar BrainforgeUK BrainforgeUK - close - 16 May 2019
avatar laoneo
laoneo - comment - 17 May 2019

You can just commit and push to the same branch and then the pr gets updated. No need to open a new pr.

Add a Comment

Login with GitHub to post a comment