[#24895] - [4.0] Add filter to com_tags administration based on root tag
- Closed
- 2 Aug 2020
- Medium
- Build: 4.0-dev
- # 24895
- Diff
- mattiaverga:tag_filter_j4
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR will add a new filter to the administration page of com_tags which makes possible to list only tags under a specific root tag.
This is useful when having a complex tag tree with a lot of levels: it lets you focus only on the desired root tag and its subtags.
When applied, the filter uses a recursive query to create a table with the subset of the root tag and its sub-tags, then the other filters are applied on this temporary table to get the final result.
Testing Instructions
Create some main level tags and some nested tags under them.
Use the new filter tab to list only tags under one main tag (or under one of the nested tags).
Expected result
When the filter is applied, the lists should show only the root tag and its child tags.
Actual result
There is no such option to achieve that.
Documentation Changes Required
The help section about com_tags should be updated with a paragraph for the new filter.
Additional comments
There seems to be a bug in displaying the tag field: setting the multiple option to false prevents the hint to be showed:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Administration Language & Strings |
| Labels |
Added:
?
?
|
||
I have tested this item
There is no items to select. You have to start typing the tag you want select. Futhermore the Label for the dropdown is missing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24895.
Screenshot to the failed test:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24895.
I have tested this item red_circle unsuccessfully on 304219f
There is no items to select. You have to start typing the tag you want select.
Yes, that's exactly how it works. It's the same for the tag filter in the Content component.
Futhermore the Label for the dropdown is missing.
As I wrote in my first comment, that's a bug in how Joomla displays the tag filter. By setting the option multiple="true" the hint is displayed, but here we need multiple="false", so it doesn't show the hint:
@mattiaverga can you please change "root" to "parent" everywhere? Root tag is an actual tag in #__tags table and its the parent of all other tags. So let's not confuse these two.
@mattiaverga can you please change "root" to "parent" everywhere? Root tag is an actual tag in
#__tagstable and its the parent of all other tags. So let's not confuse these two.
mmm I think that "parent" can be confusing: the filter will display all child levels under the chosen tag, not only the first level.
Is "base tag" more appropriate? Or maybe "starting"... I'm not an English native speaker, so I'm open to suggestions.
@mattiaverga Do you have any interest in fixing the conflicts and picking this up or should the PR be closed?
I have no more interest in this and currently I don't have free time to look at this, so I'll just close the PR
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-02 07:58:21 |
| Closed_By | ⇒ | mattiaverga | |
| Labels |
Added:
Conflicting Files
|
||
I have tested this item✅ successfully on 304219f
Selecting a parent tag also shows the children (as intended):
The only issue is that the proposal list does not contain the items:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24895.