[#24879] - [4.0] [mod_tags_similar] Always render module layout
- Fixed in Code Base
- 7 Jun 2019
- Medium
- Build: 4.0-dev
- # 24879
- Diff
- SharkyKZ:j4/modTagsSimilar
- Success Hound No violations found. Woof! Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #20810. Redo of #20811 for 4.0.
Summary of Changes
Moves early return when no items are found to the layout. This way the layout is always rendered, allowing users to show custom content when no items are found.
Also removes previously unused message.
Testing Instructions
On a site without tagged items publish Tags - Similar module.
Create module's layout override containing some custom code/message.
Check if the module is displayed.
Expected result
Module is displayed.
Actual result
Module not displayed.
Documentation Changes Required
Probably not.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings Modules Front End |
But it's the better solution, the layout should decide what it should do if the list is empty.
@brianteeman see discussion in #20811. If you're talking about empty module positions appearing in templates, we get them anyways. There's a PR #19416 for fixing that.
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24879.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24879.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24879.
| Title |
|
||||||
| Title |
|
||||||
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-07 23:33:36 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I am not in favour of this change as we have had lots of requests to ensure that a module is not rendered at all if there is no content - this does the opposite