Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24864] - [4.0] Fix filter for workflows

? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
12 May 2019

Pull Request for Issue #24814

Summary of Changes

The #__workflows table uses column name published. This causes several issues. One of them is that the ordering of workflows via state is not possible.
Another isssue is that filters are not set, as described in the related issue.

Testing Instructions

Ordering:
You must have at least two workflows. Set one of the unpublished and try ordering of the column "state"
Active Filters:
Or see test instruction in the related issue.

Expected result

Columns are ordered new if possible
Active Filters are set

Actual result

No ordering possible, active Filters are not set.

Documentation Changes Required

no, it is a bug

avatar chmst chmst - open - 12 May 2019
avatar chmst chmst - change - 12 May 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2019
Category ⇒ Administration com_workflow
avatar franz-wohlkoenig franz-wohlkoenig - change - 12 May 2019
The description was changed
avatar franz-wohlkoenig franz-wohlkoenig - edited - 12 May 2019
avatar Quy
Quy - comment - 12 May 2019

Please update to the right issue for this PR.

avatar chmst chmst - change - 12 May 2019
The description was changed
avatar chmst chmst - edited - 12 May 2019
avatar chmst
chmst - comment - 12 May 2019

done, sry

avatar Quy
Quy - comment - 12 May 2019

I have tested this item ✅ successfully on eafbd9c

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24864.

avatar Quy Quy - test_item - 12 May 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 May 2019

I dont see how this has anything to do with #24814

avatar chmst
chmst - comment - 12 May 2019

Could you test please? I think setting the filter right does the trick also for you.

avatar brianteeman
brianteeman - comment - 12 May 2019

I did test

avatar chmst chmst - change - 13 May 2019
Title
…
[4.0] Fix ordering of workflows in column "status"
[4.0] Fix filter for workflows
avatar chmst chmst - edited - 13 May 2019
avatar chmst chmst - change - 13 May 2019
The description was changed
avatar chmst chmst - edited - 13 May 2019
avatar chmst
chmst - comment - 13 May 2019

Description changed.

avatar chmst chmst - change - 20 May 2019
Labels Added: ?
avatar ReLater
ReLater - comment - 20 May 2019

I have tested this item ✅ successfully on 3e45bc5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24864.

avatar ReLater
ReLater - comment - 20 May 2019

I have tested this item ✅ successfully on 3e45bc5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24864.

avatar ReLater ReLater - test_item - 20 May 2019 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 May 2019

@Quy can you please retest?

avatar Quy
Quy - comment - 20 May 2019

I have tested this item ✅ successfully on 3e45bc5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24864.

avatar Quy Quy - change - 20 May 2019
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 20 May 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24864.

avatar Quy Quy - test_item - 20 May 2019 - Tested successfully
avatar roland-d roland-d - close - 23 May 2019
avatar roland-d roland-d - merge - 23 May 2019
avatar roland-d roland-d - change - 23 May 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-05-23 06:17:15
Closed_By ⇒ roland-d
Labels Added: ?
avatar roland-d
roland-d - comment - 23 May 2019

Thank you.

As stated this solves a different issue than #24814

Add a Comment

Login with GitHub to post a comment