J4 Issue ?
avatar brianteeman
brianteeman
12 May 2019

As the title says - there is still a lot of code referring to the sidebar in the views that we are not using

avatar brianteeman brianteeman - open - 12 May 2019
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 12 May 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 12 May 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 12 May 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 12 May 2019
Status New Discussion
avatar SharkyKZ
SharkyKZ - comment - 12 May 2019

Should note that removing these prevents plugins from modifying the sidebar.

avatar brianteeman
brianteeman - comment - 12 May 2019

obviously without a sidebar there is nothing for the plugin to modify ;)

avatar SharkyKZ
SharkyKZ - comment - 13 May 2019

After this there won't be. But currently plugins can add entries even if the sidebar is otherwise empty. Isn't that why there is !empty($this->sidebar) check in the first place?

avatar mbabker
mbabker - comment - 13 May 2019

Even if plugins can conceptually manipulate these sidebars (hint, you don't really have an event in most admin components between the time they seed the sidebars and the time they are rendered), the fact is the sidebar rendering has been FUBAR since the introduction of customizable admin menus because the sidebar is not in-sync with those menus or user customizable in any way. Just get rid of the sidebars already and if it is reintroduced it should be done correctly (seeded based on menu settings, proper event for customization, etc. etc.).

avatar SharkyKZ
SharkyKZ - comment - 15 May 2019

OK, just wanted to make sure. I guess it should be removed from Joomla\CMS\MVC\View\ListView too?

avatar brianteeman
brianteeman - comment - 15 May 2019

There are still some components not yet converted

avatar brianteeman brianteeman - change - 6 Aug 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-08-06 22:30:47
Closed_By brianteeman
avatar brianteeman
brianteeman - comment - 6 Aug 2019

closed as there are pr for the outstanding uses in contacts and finder

avatar brianteeman brianteeman - close - 6 Aug 2019

Add a Comment

Login with GitHub to post a comment