? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 May 2019

Update the markup for consistency with other similar views eg new access level form

before

image

after

image

avatar brianteeman brianteeman - open - 10 May 2019
avatar brianteeman brianteeman - change - 10 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2019
Category Administration com_users
avatar SharkyKZ
SharkyKZ - comment - 10 May 2019

That markup was added so form could be extended by plugins. See #21696.

avatar brianteeman
brianteeman - comment - 10 May 2019

@SharkyKZ well it obviously needs to be changed in some way so at least it looks consistent. Perhaps only using the tabset if there is more than one tab?

avatar SharkyKZ
SharkyKZ - comment - 10 May 2019

IMO, just converting tabs from Bootstrap to CE would be enough.

avatar brianteeman
brianteeman - comment - 10 May 2019

@SharkyKZ I think you may be right. Will try to make the changes over the weekend

avatar brianteeman brianteeman - change - 12 May 2019
Labels Added: ?
avatar brianteeman brianteeman - change - 12 May 2019
The description was changed
avatar brianteeman brianteeman - edited - 12 May 2019
avatar brianteeman brianteeman - change - 12 May 2019
The description was changed
avatar brianteeman brianteeman - edited - 12 May 2019
avatar brianteeman
brianteeman - comment - 12 May 2019

Updated from bs to ce as per suggestion from @SharkyKZ and updated screenshots in the original post

avatar tonypartridge
tonypartridge - comment - 13 Jul 2019

@brianteeman can you resolve conflict and review Quy's changes then ill test

avatar brianteeman
brianteeman - comment - 15 Jul 2019

@tonypartridge conflicts resolved etc

avatar Quy
Quy - comment - 15 Jul 2019

@brianteeman Please check as the only change is new lines.

avatar brianteeman
brianteeman - comment - 15 Jul 2019

Closing as there were changes made elsewhere that make the original version of this redundant (and why there was nothing left of the pr after updating the branch)

avatar brianteeman brianteeman - close - 15 Jul 2019
avatar brianteeman brianteeman - change - 15 Jul 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-07-15 22:31:23
Closed_By brianteeman

Add a Comment

Login with GitHub to post a comment