? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 May 2019

Update the layout for the versions toolbar button to use the custom element used by the other toolbar buttons

Testing by code review

Pull Request for part of Issue #24850 .

avatar brianteeman brianteeman - open - 10 May 2019
avatar brianteeman brianteeman - change - 10 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2019
Category Layout
avatar Quy
Quy - comment - 12 May 2019

I have tested this item successfully on 3973061


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24852.

avatar Quy Quy - test_item - 12 May 2019 - Tested successfully
avatar wilsonge
wilsonge - comment - 13 May 2019

We need the HtmlHelper imports please

HTMLHelper::_('behavior.core');
HTMLHelper::_('webcomponent', 'system/joomla-toolbar-button.min.js', ['version' => 'auto', 'relative' => true]);
avatar brianteeman
brianteeman - comment - 13 May 2019

yeah - sorry - I spotted that last night and forgot to update

20e2507 13 May 2019 avatar brianteeman js
avatar brianteeman brianteeman - change - 13 May 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 13 May 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-13 11:06:03
Closed_By wilsonge
avatar wilsonge wilsonge - close - 13 May 2019
avatar wilsonge wilsonge - merge - 13 May 2019
avatar wilsonge
wilsonge - comment - 13 May 2019

Thanks!

avatar brianteeman
brianteeman - comment - 13 May 2019

Thanks

Add a Comment

Login with GitHub to post a comment