Feeling Lucky
?
[#24847] - [4.0] Fix actionlog message value
- Fixed in Code Base
- 10 May 2019
- Medium
- Build: 4.0-dev
- # 24847
- Diff
- twister65:4.0-actionlog
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #24846 .
Summary of Changes
Load language on after initialise.
Testing Instructions
- Enable/Disable a plugin.
- Add/Update/Delete an extension, an article, an user, a group.
- Publish/Unpublish/Trash/Archive an article, a categorie, a menu.
- See the Latest Actions module in the Control Panel
Expected result
No constant value, the actionlog message is translated.
Actual result
As expected result.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
| Title |
|
||||||
infograf768
- comment
- 10 May 2019
Diff would be
diff --git a/plugins/system/actionlogs/actionlogs.php b/plugins/system/actionlogs/actionlogs.php
index 521b510..0d4f97d 100644
--- a/plugins/system/actionlogs/actionlogs.php
+++ b/plugins/system/actionlogs/actionlogs.php
@@ -64,4 +64,23 @@
/**
+ * Listener for the `onAfterInitialise` event
+ *
+ * @return void
+ *
+ * @since 4.0
+ */
+ public function onAfterInitialise()
+ {
+ if (!$this->app->isClient('administrator'))
+ {
+ return;
+ }
+
+ // Load plugin language files only when needed (ex: they are not needed in site client).
+ $this->loadLanguage();
+ }
+
+
+ /**
* Adds additional fields to the user editing form for logs e-mail notifications
*
infograf768
- comment
- 10 May 2019
@twister65
Please modify your PR with the code above.
| Labels |
Added:
?
?
|
||
| Category | Administration Language & Strings Front End Plugins | ⇒ | Front End Plugins |
| Labels |
Removed:
?
|
||
infograf768
- comment
- 10 May 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24847.
infograf768
- comment
- 10 May 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24847.
wilsonge
- comment
- 10 May 2019
protected $autoloadLanguage = true; you need to remove this class property otherwise it will always be loaded in the constructor anyhow?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-10 21:18:36 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 10 May 2019
Thanks!
This is not the right fix. The underlying issue has been discussed here #17444. Until it is fixed, plugin language files can be loaded manually with
$this->loadLanguage()inonAfterInitialise().