[#24843] - Prevent redirecting ajax calls
- Closed
- 13 Jun 2019
- Medium
- Build: staging
- # 24843
- Diff
- tgv604:staging
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr Build is passing Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
This PR fixes an issue appearing when ajax-based form elements are present on the user profile form. Ajax calls made through use of com_ajax return profile editing pages instead of whatever they're meant to return, potentially breaking the form.
Please note there's no such elements in vanilla Joomla setup, but they may be added with custom user profile plugins (example: states/provinces dropdown list refreshing on country change, async loading of transactions history from 3rd party resources etc.)
Pull Request for Issue # n/a
Summary of Changes
Added a check for com_ajax to stop redirections to profile for ajax calls
Testing Instructions
requires custom user plugin/s with ajax-based form elements (the issue only affects such elements)
Expected result
ajax calls returning their payload (json structures, html, etc.)
Actual result
ajax calls returning profile editing page html
Documentation Changes Required
n/a
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Category | Front End Plugins | ⇒ | Libraries Front End Plugins |
| Category | Front End Plugins Libraries | ⇒ | Front End Plugins |
| Category | Front End Plugins | ⇒ | Unit Tests Administration com_admin SQL Postgresql MS SQL com_categories com_config com_contact com_content com_fields com_joomlaupdate |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-13 10:08:29 |
| Closed_By | ⇒ | tgv604 | |
| Labels |
Added:
?
|
||
To clarify: one of my sites with privacy plugin enabled has also an address profile tab with nice dynamic country & states dropdowns, which work through com_ajax -- and they completely mess up the form when the privacy consent isn't given yet.