Feeling Lucky
?
[#2484] - Cleanup code for mod_finder
- Closed
- 23 Dec 2013
- Medium
- Build: master
- # 2484
- Diff
- Bakual:ModFinder
- Foreign ID 32638
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Main thing of this PR is to make the set_itemid parameter so it uses the menuitem formfield instead of a text formfield. This lets users easily choose a menu item instead of looking up the id in the menu manager.
I did some other cleanups while working with he code:
- Change
show_autosuggestfrom list to radio formfield and added classes so it shows as red/green buttons - Moved the
alt_labelparameter below theshow_labelparameter as it makes more sense there - Adjusted some default values to be in line with the default values in the code. If the are objections with this it can be easily changed. My only concern is to have them consistent in the XML file and in the code.
- Removed
JHtml::_('behavior.framework');. We don't use Mootools anymore and JQuery is loaded together with the tooltips anyway. So no need to specifially load the framework. - Cleaned up code related to the
switchstatements forbutton_posandlabel_pos - Removed an unneeded
iffor theshow_advancedparameter
I think there should be no changes at all for existing sites.
Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32638