? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
7 May 2019

This updates the PHP versions used for the unittests

avatar Hackwar Hackwar - open - 7 May 2019
avatar Hackwar Hackwar - change - 7 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2019
Category Unit Tests
avatar Hackwar Hackwar - change - 7 May 2019
Labels Added: ? ?
avatar SniperSister
SniperSister - comment - 8 May 2019

Nice one, thanks @Hackwar! I assume that we need a Cronjob on the drone machine fetching the new daily images once a day?

avatar Hackwar
Hackwar - comment - 8 May 2019

As far as I can see we would just have to clear the docker image cache for the new image to be built from the sources. I would even say that once a week would be enough. We could add an attribute to those steps to never cache these images, but that seems excessive and would extend build times...

avatar SniperSister
SniperSister - comment - 8 May 2019

As far as I can see we would just have to clear the docker image cache for the new image to be built from the sources.

Exactly, so we need the cron once it's merged :) ping me, i can take care of that

avatar Hackwar
Hackwar - comment - 8 May 2019

done

avatar Hackwar
Hackwar - comment - 8 May 2019

done

avatar Hackwar
Hackwar - comment - 8 May 2019

Somehow it doesn't save my comments, but I just wanted to let you know that I did the change.

avatar wilsonge
wilsonge - comment - 8 May 2019

This looks fine on review to me

avatar SniperSister SniperSister - change - 8 May 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-08 19:50:16
Closed_By SniperSister
avatar SniperSister SniperSister - close - 8 May 2019
avatar SniperSister SniperSister - merge - 8 May 2019
avatar SniperSister
SniperSister - comment - 8 May 2019

Merged! Thanks :)

avatar Hackwar
Hackwar - comment - 8 May 2019

Just to make sure that you are not missing something: Yes, this looks fine right now, but it has a lot less PHP modules/extensions than our current image. So when we extend the unit tests to test other stuff, we will have to revisit this topic. But for now this is the quickest solution to move forward here. For integration tests we will have to also extend this, I guess. But for now, this gets us the unit tests onto PHP 7.2/.3/.4/8.0 quickly and removes the need for Travis in 4.0-dev.

avatar SniperSister
SniperSister - comment - 8 May 2019

@Hackwar suggestion: adding a php -v before running the tests should give us some debug info in case we run into issues - what do you think?

Add a Comment

Login with GitHub to post a comment