[#24817] - [4.0] Improve Text on Modal: Batch process language labels
- Closed
- 26 Mar 2020
- Medium
- Build: 4.0-dev
- # 24817
- Diff
- pe7er:batch-process-language-labels
- Success Hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
IMHO some of the text in the Batch process the selected articles modal is too long:
- "To Move or Copy your selection please select a Category."
- "Do you want to move the items or make a copy of them?"
This PR rewrites that text to:
- "Select a Category for your Selection"
- "Copy or Move the items?"
Summary of Changes
On the current modal some of the text seems a bit too long:
Testing Instructions
Content > Articles > select some articles > click on Batch
Select a category so that the Copy / Move question is shown.
Expected result
This PR makes two of the labels shorter so that IMHO it looks nicer,
but also easier to read and understand:
Suggestion (NOT in this patch)
If this PR gets accepted then I suggest to move the radio buttons of Copy / Move to the left
by removing the left margin in administrator/templates/atum/css/template.css line 470:
.control-group .controls {
margin-left: 220px;
}| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration Language & Strings |
The length of the text should not be a consideration as it will always be different lengths in other languages
The length of the text should not be a consideration as it will always be different lengths in other languages
I know. Could you please look at the suggested improvement itself (besides the length) ?
Although I do like the change for
JLIB_HTML_BATCH_MOVE_QUESTION="Copy or Move the items?"
I am not sure for the other one as it gives the feeling that one HAS to select a category.
| Labels |
Added:
?
?
|
||
Is it necessary to include for your Selection and the items? This is not done with the other labels.
Plus, it is implied in the heading Batch process the selected articles.
Maybe remove the second label and replace the first label with Move or Copy to Category.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24817.
I have tested this item
It works
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24817.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24817.
I agree with JM here to an extent. Whilst I think it's clear you don't have to select a category (as the default is "Don't move or copy". Which is the same for all other options that modify data (otherwise you can argue they are all also issues), I would imagine the default string in the value field being the only way of understanding you can move or copy items could be confusing to people unfamiliar to batch (I hesitate to say new users because batch isn't exactly a brand new user feature)
I'd be interested in hearing more opinions here before merging (clearly no need to more testers as the patch itself is self-explanatory)
| Status | Ready to Commit | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-26 03:27:41 |
| Closed_By | ⇒ | Quy |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24817
Please continue discussion/testing in PR #28447.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24817.
I can create a similar PR for: