? ? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
6 May 2019

Summary of Changes

As title says. Missing
COM_TEMPLATES_TEMPLATE_NO_PREVIEW_ADMIN="No preview available for Administrator templates."

EDIT: Instead of adding the string, modifying tmpl to not display it.

Testing Instructions

Display admin templates

Before patch

Screen Shot 2019-05-06 at 08 33 12

After patch

Screen Shot 2019-05-07 at 07 56 11

avatar infograf768 infograf768 - open - 6 May 2019
avatar infograf768 infograf768 - change - 6 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 May 2019
Category Administration Language & Strings
avatar Quy
Quy - comment - 6 May 2019

It was removed in PR #24440. How about not displaying the string, thus no need to add the string?

avatar infograf768
infograf768 - comment - 7 May 2019

It was removed in PR #24440. How about not displaying the string, thus no need to add the string?

Fine for me.

avatar infograf768 infograf768 - change - 7 May 2019
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2019
Category Administration Language & Strings Administration com_templates
avatar infograf768
infograf768 - comment - 7 May 2019

@Quy Done.
Screen Shot 2019-05-07 at 07 56 11

avatar infograf768 infograf768 - change - 7 May 2019
Title
[4.0] [com_templates] Missing lang string
[4.0] [com_templates] Admin template does not need Preview message
avatar infograf768 infograf768 - edited - 7 May 2019
avatar infograf768 infograf768 - change - 7 May 2019
The description was changed
avatar infograf768 infograf768 - edited - 7 May 2019
avatar infograf768 infograf768 - change - 7 May 2019
Labels Removed: ?
avatar Quy
Quy - comment - 7 May 2019

I have tested this item successfully on 529b494


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24811.

avatar Quy Quy - test_item - 7 May 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 7 May 2019
avatar chmst
chmst - comment - 7 May 2019

I have tested this item successfully on 65b3cb6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24811.

avatar chmst chmst - test_item - 7 May 2019 - Tested successfully
avatar alikon alikon - change - 7 May 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 7 May 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24811.

avatar alikon
alikon - comment - 7 May 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24811.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 May 2019

@infograf768 can this be set on RTC or aretest by @Quy is needed?

avatar infograf768 infograf768 - alter_testresult - 7 May 2019 - Quy: Tested successfully
avatar Quy
Quy - comment - 7 May 2019

No changes since my test so it is good to go.

avatar SniperSister SniperSister - change - 9 May 2019
Labels Added: ?
avatar wilsonge wilsonge - close - 13 May 2019
avatar wilsonge wilsonge - merge - 13 May 2019
avatar wilsonge wilsonge - change - 13 May 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-13 11:14:22
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 13 May 2019

Thanks!

Add a Comment

Login with GitHub to post a comment