? ? Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
5 May 2019

Some language labels had references to COM_USER (without the S).
There's no component called COM_USER; it's name is COM_USERS.

This PR replaces COM_USER_ with COM_USERS_ in the en-GB language files
and references in PHP + XML files.

avatar pe7er pe7er - open - 5 May 2019
avatar pe7er pe7er - change - 5 May 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2019
Category Administration Language & Strings Front End com_users
avatar pe7er pe7er - change - 5 May 2019
Labels Added: ? ?
avatar ReLater
ReLater - comment - 5 May 2019

It looks like some string changes are missing. Example: See line

<layout title="com_user_login_view_default_title" option="com_user_login_view_default_option">

avatar pe7er
pe7er - comment - 5 May 2019

com_user_

Well spotted. I've fixed that... Thanks @ReLater !

avatar infograf768
infograf768 - comment - 6 May 2019

Any reason to use lowercase? Looks like this is not normalized in core. Some are lowercase, others are uppercase.

avatar ReLater
ReLater - comment - 6 May 2019

Any reason to use lowercase?

No, no reason. Just taken over from earlier Joomla versions. All can be uppercase.

avatar ReLater
ReLater - comment - 6 May 2019

I don't have the time to create a pr in this week. Shall I open an issue as reminder?

avatar pe7er
pe7er - comment - 6 May 2019

I'll create a PR for that...

avatar pe7er
pe7er - comment - 6 May 2019

Done!
PR: #24815

avatar pe7er
pe7er - comment - 7 May 2019

Closing this issue...
To solve the merge conflicts it was easier to create a new PR for this issue: #24825

avatar pe7er pe7er - change - 7 May 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-05-07 11:40:43
Closed_By pe7er
avatar pe7er pe7er - close - 7 May 2019

Add a Comment

Login with GitHub to post a comment