Feeling Lucky
NPM Resource Changed
?
[#24779] - Update node packages to latest and greatest
- Fixed in Code Base
- 4 May 2019
- Medium
- Build: 4.0-dev
- # 24779
- Diff
- wilsonge:feature/update-node-versions
- Success Hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
Updates our node dependencies to latest versions
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-04 09:51:28 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
NPM Resource Changed
?
|
||
joomla-cms-bot
- | Category | ⇒ | NPM Change |
wilsonge
- comment
- 4 May 2019
Does look like the release of 1.1.4 is enough to solve the issues we needed to patch before. So can go to that indeed (although we probably need the accessibility fixes too) in the latest branch.
Please create an issue for node-sass because i can't reproduce still
npm installgives:https://github.com/wilsonge/joomla-cms/blob/d3a68fd414aea5b2c85e78ec4dbac3ecbe22a376/package.json#L28
Replace by (See #23597):
"awesomplete": "1.1.4",I also have a problem with nodesass.
Question: How can a PR be merged without testing ?