[#24774] - [4.0] com_languages sidebar
- Fixed in Code Base
- 14 May 2019
- Medium
- Build: 4.0-dev
- # 24774
- Diff
- brianteeman:lang_sidebar
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Continuing the work to remove the sidebar submenu. This pr removes it from Languages, Content Languages and Overrides.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_languages |
| Labels |
Added:
?
|
||
Remove use Joomla\Component\Languages\Administrator\Helper\LanguagesHelper;
From where? That doesn't exist as far as I can see
In HtmlView.php files at the top in the use area.
use Joomla\CMS\Helper\ContentHelper;
use Joomla\CMS\Language\Text;
use Joomla\CMS\MVC\View\HtmlView as BaseHtmlView;
use Joomla\CMS\Toolbar\Toolbar;
use Joomla\CMS\Toolbar\ToolbarHelper;
use Joomla\Component\Languages\Administrator\Helper\LanguagesHelper;
I see it now but I think other functions in that helper are being used
Searched the 3 files and it was only used for the addSubmenu.
@brianteeman I'm using PhpStorm and that is displaying if something is used:
Light grey means not in use, so LanguagesHelper can be cleaned up (for all 3 HtmlView.php files).
Yeah I will fix it this afternoon
Updated as requested
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24774.
| Category | Administration com_languages | ⇒ | Administration com_languages Language & Strings |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24774.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24774.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24774.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-14 18:28:01 |
| Closed_By | ⇒ | SniperSister |
Merged, Thanks!
thanks
Remove
use Joomla\Component\Languages\Administrator\Helper\LanguagesHelper;