[#24771] - [4.0] Fix schema updates for com_finder with PostgreSQL database
- Fixed in Code Base
- 3 May 2019
- Medium
- Build: 4.0-dev
- # 24771
- Diff
- richard67:4.0-dev-fix-finder-pgsql-1
- Success Hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #24769 .
Summary of Changes
Fix the schema update changes from PR #20561 for PostgreSQL so they are consistent with a new installation.
Testing Instructions
- Pull current (May 1, 2019) 4.0-dev branch and do
composer installandnpm ci, or use nightly build from tonight. Both include PR #24747, which is needed to install on PostgreSQL. Alpha 8 does not include that yet, so please don't use Alpha 8. - Run installation using a PostgreSQL database.
- After installation has finished with success, login to backend, confirm the statistics dialog, then goto the system panel and check section "Information - Database". Result: You see that there is 1 database problem.
- Click "Database" to get to the Database view. Result: See section "Actual result" below.
- Apply changes from this PR.
- Leave database view and go back to it again. Result: See section "Expected result" below.
Expected result
No database problems.
Actual result
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Postgresql SQL Administration com_admin |
@alikon Could you test?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771.
| Category | Postgresql SQL Administration com_admin | ⇒ | Administration com_admin com_finder Postgresql SQL |
Drone failure is not related to this PR. Phpcs was successful. It was the prepare step which failed.
| Category | Postgresql SQL Administration com_admin com_finder | ⇒ | Postgresql SQL Administration com_admin |
@twister65 I noticed you test with PostgreSQL, too. If you have time, could you test my PR here? Thanks in advance if so.
| Labels |
Added:
?
|
||
Drone failure again is not related to this PR. Phpcs was successful. This time it was analysis4x which failed.
I have tested this item
Tested with Joomla_4.0.0-alpha9-dev nightly build.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771.
I have tested this item
Tested with Joomla_4.0.0-alpha9-dev nightly build.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771.
@zero-24 @SniperSister rips please
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-03 12:06:59 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
It’s the tool we use for the security analysis part of drone (which was failing). It’s now passing so I can merge this! Thanks!
Thanks!
@alikon Could you test?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771.