Feeling Lucky
?
?
[#24757] - [4.0] Added the module ID to the forms HTML id so that it is unqiue and you…
- Fixed in Code Base
- 5 May 2019
- Medium
- Build: 4.0-dev
- # 24757
- Diff
- uglyeoin:4.0-dev
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
… can have multiple login forms.
Pull Request for Issue # .
Summary of Changes
Added the module ID to the HTML ID making it unique and allowing for multiple login forms.
Testing Instructions
Add a login module to the front end
Inspect the source code and see that the login module has an id of id="login-form"
Install the patch
Inspect the login form and see that the module now has an ID with a module number added to the end of it. e.g. id="login-form-16"
Expected result
ID's should always be unique
Actual result
ID is static but module can be replicated.
You see the correct module ID attached to the ID making it unique
Documentation Changes Required
n/a
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
franz-wohlkoenig
- | Title |
|
||||||
alikon
- comment
- 5 May 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24757.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 5 May 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24757.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-05 11:55:58 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 5 May 2019
Thanks!
I have tested this item✅ successfully on 6a0a65f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24757.