? Error

User tests: Successful: Unsuccessful:

avatar obsidev
obsidev
10 Nov 2013

Do not put a PHP warning message if the type of the enqueueMessage is not defined in the template.

avatar obsidev obsidev - open - 10 Nov 2013
avatar brianteeman
brianteeman - comment - 10 Nov 2013

Thanks for your contribution - At this time we are only using github as the place to submit code fixes, the actual reporting of issues and testing fixes is still taking place on Joomlacode.

Please can you:

1) Open an item on the Joomlacode tracker in the appropriate area.

CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103

CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549

avatar brianteeman brianteeman - close - 10 Nov 2013
avatar brianteeman
brianteeman - comment - 10 Nov 2013

Oops sorry this should not have been closed but please
After submitting the item to the Joomlacode tracker, add a link to the Joomlacode tracker item here and make sure that you add a link to this GitHub issue or pull request on the joomlacode tracker item.

avatar brianteeman brianteeman - reopen - 10 Nov 2013
avatar obsidev
obsidev - comment - 11 Nov 2013

Yeah I know that it is better to create an issue in joomlacode, I just didn't have the time to when I submitted the patch. I didn't want to loose a conference during the JWC ;-)

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32650&start=0

avatar tompap
tompap - comment - 11 Nov 2013

Bug confirmed on joomlacode.

But I think a better fix will be to:

update the new "redirect" function in cms/application/cms.php

// Set the message type if present
if (isset($args[2]) && !empty($args[2])) {

....
} else {
.... $type = null ======> Instead of $type = "message";
}

and replace $type = null to $type = "message".

This will be better for backward compatibility.

avatar infograf768
infograf768 - comment - 14 Nov 2013

Where do we stand here?

avatar brianteeman
brianteeman - comment - 8 Aug 2014

closed as this was replaced by #4013 which was merged

Add a Comment

Login with GitHub to post a comment