? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
28 Apr 2019

Summary of Changes

The APIs that phpDocumentor uses to parse doc blocks has special handling for certain tags (@param, @property, @property-read, @property-write, and @var) to extract type information from the tag if properly structured, otherwise all of the text is considered as part of a description (or depending on the tag type some other internal properties that we aren't going to get into here unless you really want to learn the internals of phpDocumentor's doc block parsing libraries). So this pull request changes the doc blocks for constants in the API from @const tags to @var tags so that the type information is correctly extracted by the API. Additional minor PHPCS tweaks are made in affected doc blocks as well to conform to suggested structure or add descriptions where they didn't previously exist.

Testing Instructions

Code review; the changes made here are only going to impact the resulting output for https://api.joomla.org

avatar mbabker mbabker - open - 28 Apr 2019
avatar mbabker mbabker - change - 28 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Apr 2019
Category Libraries Front End Plugins
avatar zero-24
zero-24 - comment - 28 Apr 2019

Merging on review. thank you @mbabker

avatar zero-24 zero-24 - change - 28 Apr 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-28 07:36:17
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 28 Apr 2019
avatar zero-24 zero-24 - merge - 28 Apr 2019

Add a Comment

Login with GitHub to post a comment