User tests: Successful: Unsuccessful:
Pull Request for Issue #22884 .
Added a condition if user is not admin before filtering by access level
Instructions copied from issue by franz-wohlkoenig:
The Guest status article category to show in the results.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Title |
|
This looks wrong to me. The solution is in the screenshot here #22884 (comment)
@brianteeman Shouldn't the superuser have access over any group? This behavior exists in other components
joomla-cms/plugins/search/tags/tags.php
Line 123 in fe597ef
Groups which are used for ACL are different from the viewing access levels and the two systems should not be making assumptions based on the other. As I've said about a thousand times now, someone really just needs to sit down and refactor the code if you really want the viewing access level logic to behave differently based on the ACL code and stop plugging in random if (!Factory::getUser()->authorise('core.admin')) {}
checks because that is not fixing the problem, that is just working around it.
Since there is this weird desire to couple the viewing access level system to the ACL system (two completely unrelated systems) and only for super users, a solution I have mentioned in the past is to adapt Joomla\CMS\User\User::getAuthorisedViewLevels()
and its internals to assign all view levels to super users.
Other solutions include the deprecation of the viewing access level system in favor of a core.view
or core.read
ACL permission and have everything reside in one system, but given the ACL system's lack of scalability, this probably isn't something that will work well in the long run without a major refactoring of the ACL system.
ok, the access level is faster as the ACL I think, so returning all access levels for the super users would be the solution with less negativ impact. Maybe we find someone that could do this for J4.
I would close this here because its the wrong solution.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-29 14:36:28 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
?
|
I have tested this item✅ successfully on 914f5ca
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24741.