[#24737] - batch copy permission on module
- Fixed in Code Base
- 18 May 2019
- Medium
- Build: staging
- # 24737
- Diff
- alikon:patch-121
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
follow up #24730 for module batch copy.
Summary of Changes
let's copy permission too
Testing Instructions
- Create/edit a module.
- Go to its permission tab and make a change. (e.g registered->allow creating)
- Go to Batch and Copy it somewhere else.
Expected result
the permission are copyied too
Actual result
permission are not copied
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules |
| Labels |
Added:
?
|
||
I have tested this item
I've tested with 2 modules which had differenc ACL modifications.
Both modules copied together in 1 batch action.
Before patch: Copied modules have ACL like in new modules.
After patch: Each of the module copies has ACL like the particular copy source module.
Drone error (javascript) seems not to be related to this PR. Code style is ok.
@HLeithner and @wilsonge Release leads please check as also with PR #24730 and PR #24736 if this is a bug fix so it goes into 3.9.next or a new feature for 4.0.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24737.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24737.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
relaunch drone
@franz-wohlkoenig Any reason why this is not merged? Has 2 good tests, has RTC. Only thing is it needs a "rebase" (i.e. merge from staging).
| Labels |
Added:
?
|
||
Rebased. @HLeithner please decide if merging in 3.9
HLeithner
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-18 12:24:49 |
| Closed_By | ⇒ | HLeithner |
Any progress on that?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24737.
I have tested this item✅ successfully on 8f074f3
I've tested with 2 modules which had differenc ACL modifications.
Both modules copied together in 1 batch action.
Before patch: Copied modules have ACL like in new modules.
After patch: Each of the module copies has ACL like the particular copy source module.
Drone error (javascript) seems not to be related to this PR. Code style is ok.
@HLeithner and @wilsonge Release leads please check as also with PR #24730 and PR #24736 if this is a bug fix so it goes into 3.9.next or a new feature for 4.0.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24737.