@rdeutz @yvesh @puneet0191 can you guys take a look please. This looks good to me. But unsure if there was anything specific about our image that made us build our own

@wilsonge I think it should be fine, as long as the version of PHPUnit we use is the same in both the images and all required extensions are enabled.

The version of PHPUnit depends on our composer.json and not on the image.

Wooooooah!

The bigger question for me would be about the supported PHP modules. I stumbled upon images where no postgres support was available.

I stumbled upon images where no postgres support was available.

Is the CMS even running any tests on a PostgreSQL environment? I think this recent "can't even install using PostgreSQL" issue would've been identified and resolved sooner if the system tests had both a MySQL and PostgreSQL run.

in j3 we're running unit tests on the jdatabasepostgres classes (which is obviously done in the database framework package in j4 so effectively we're not testing anything in the cms repo in j4). We're not running system tests in postgres anywhere.

There are also some DB specific adapters it’d be good to have integration
tests for (Smart Search and Schema library for the DB update logic). But a
general system test run on PostgreSQL would be my suggested priority since
those tests are already written and it should only be a new pass setting a
different DB driver for config (hopefully there isn’t too much MySQL
specific code in those).

On Sun, Apr 28, 2019 at 12:03 PM George Wilson notifications@github.com
wrote:

in j3 we're running unit tests on the jdatabasepostgres classes (which is
obviously done in the database framework package in j4 so effectively we're
not testing anything in the cms repo in j4). We're not running system tests
in postgres anywhere.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#24734 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACZ7IKJWOD3G2WHOTRCHIDPSXKH7ANCNFSM4HI2VQBA
.

--

• Michael Please pardon any errors, this message was sent from my iPhone.

yes, it should be just a few changes to Joomla Browser and Docker Setup to install Postgresql, I will make the changes sometime next week. thanks

So the only thing i'm nervy about here is us using nightly builds and the stability of them on stable PHP Versions (obviously for things like php 8 it's no big deal). If all pull requests fail for a few days because of a bad nightly then we're going to be in a bit of trouble.

Lets postpone this PR and see to update Drone first. We also want to have PHP8 and 7.4 to be able to fail at this stage without failing the whole pipeline and that is not possible in Drone 0.8. I would then invest a bit more time into this.

OK Im happy with that. I'll close for now. But with the intention of re-opening when we're ready