? ? Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
24 Apr 2019

Pull Request for Issue #24707.

Summary of Changes

Changes e-mail validator from auto detect to php native function filtar_var for php 7.3+

Testing Instructions

  1. Use php 5.3-7.3
  2. Send an email.

Expected result

Works

Actual result

Doesn't work on some hosts with php 7.3, maybe because the upgrade to PCRE2

https://www.php.net/manual/en/migration73.other-changes.php#migration73.other-changes.pcre

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar HLeithner HLeithner - open - 24 Apr 2019
avatar HLeithner HLeithner - change - 24 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2019
Category Libraries
avatar tecpromotion
tecpromotion - comment - 24 Apr 2019

I have tested this item successfully on 3d13b38

I've tested this successfully with PHP-Version 7.3.2.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24726.

avatar tecpromotion
tecpromotion - comment - 24 Apr 2019

I have tested this item successfully on 3d13b38

I've tested this successfully with PHP-Version 7.3.2.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24726.

avatar tecpromotion tecpromotion - test_item - 24 Apr 2019 - Tested successfully
avatar f-hamel
f-hamel - comment - 25 Apr 2019

I have tested this item successfully on 3d13b38


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24726.

avatar f-hamel f-hamel - test_item - 25 Apr 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 25 Apr 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Apr 2019

Status "Ready To Commit".

avatar roland-d
roland-d - comment - 25 Apr 2019

@HLeithner We have a PHPCS failure ;) Comments over multiple lines should use /* */

a6c653d 25 Apr 2019 avatar HLeithner c/s
avatar HLeithner HLeithner - change - 25 Apr 2019
Labels Added: ?
avatar zero-24
zero-24 - comment - 25 Apr 2019

Merging for 3.9.6 thanks ?

avatar zero-24 zero-24 - change - 25 Apr 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-25 11:39:51
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 25 Apr 2019
avatar zero-24 zero-24 - merge - 25 Apr 2019

Add a Comment

Login with GitHub to post a comment