? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
24 Apr 2019

We added the class JViewGenericdataexception into 4.0. Refactoring lots of code later, it feels very wrong to have this non-namespaced class and thus this here refactors all of that to a nicer namespaced version. It also removes yet another class from /libraries/joomla.

avatar Hackwar Hackwar - open - 24 Apr 2019
avatar Hackwar Hackwar - change - 24 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2019
Category Administration com_banners com_cache com_categories com_checkin com_contact com_content com_contenthistory com_csp com_fields com_finder
avatar Hackwar Hackwar - change - 24 Apr 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 24 Apr 2019

When I was doing the namespacing I wondered why this one wasn't - now I know. Thanks

avatar mbabker
mbabker - comment - 24 Apr 2019

Can you use the more grammatically correct "GenericDataException" please? It's been irking me since day 1 that the casing on the class name was funny but with namespaced classes there isn't a real need to not do it "right".

avatar Hackwar
Hackwar - comment - 24 Apr 2019

done

avatar Hackwar
Hackwar - comment - 3 May 2019

@wilsonge Do I need to do anything else to get this merged?

avatar wilsonge wilsonge - change - 4 May 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-04 07:36:50
Closed_By wilsonge
avatar wilsonge wilsonge - close - 4 May 2019
avatar wilsonge wilsonge - merge - 4 May 2019
avatar wilsonge
wilsonge - comment - 4 May 2019

Nope. RIPs was failing when I last looked which has now been fixed. Thanks!

Add a Comment

Login with GitHub to post a comment