J4 Media Manager NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
23 Apr 2019
  • Adds a aria-labelledby element to the media manager modals
  • Downgrades the role from alertdialog to dialog

@zwiastunsw @brianteeman

avatar wilsonge wilsonge - open - 23 Apr 2019
avatar wilsonge wilsonge - change - 23 Apr 2019
Status New Pending
avatar wilsonge wilsonge - change - 23 Apr 2019
The description was changed
avatar wilsonge wilsonge - edited - 23 Apr 2019
avatar joomla-cms-bot joomla-cms-bot - change - 23 Apr 2019
Category Administration com_media NPM Change
avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Apr 2019
Title
[4.0] [a11y] Improve accessibility of media manager modals
[4.0] Improve accessibility of media manager modals
avatar franz-wohlkoenig franz-wohlkoenig - edited - 23 Apr 2019
avatar brianteeman
brianteeman - comment - 23 Apr 2019

What is the modal title supposed to be for the preview

image

avatar wilsonge
wilsonge - comment - 24 Apr 2019

Screenshot 2019-04-24 at 04 43 00

The name of the image. In the red box above (I haven't changed the titles here from what they were before this patch) - I've just linked the existing headers in the header slot to an aria-labelledby tag.

avatar brianteeman
brianteeman - comment - 26 Apr 2019

Try to use the keyboard to close the modal - you can't as the keyboard is trapped inside media manager. pressing tab you will see that the next image in the manager gets focus

avatar wilsonge wilsonge - change - 27 Apr 2019
Labels Added: J4 Media Manager NPM Resource Changed ? ?
avatar wilsonge
wilsonge - comment - 27 Apr 2019

Fixed. There was nothing to lock onto as it was a link rather than a button. Changed the close to be a button and it all worked nicely

avatar wilsonge wilsonge - change - 4 May 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-04 08:38:40
Closed_By wilsonge
Labels Added: ?
Removed: ?
avatar wilsonge wilsonge - close - 4 May 2019
avatar wilsonge wilsonge - merge - 4 May 2019

Add a Comment

Login with GitHub to post a comment