? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
22 Apr 2019

In banner clients there was no class to give a background when the value was 0. For consistency with similar views this PR adds the class.

Before

image

After

image

avatar brianteeman brianteeman - open - 22 Apr 2019
avatar brianteeman brianteeman - change - 22 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2019
Category Administration com_banners
avatar richard67
richard67 - comment - 22 Apr 2019

I have tested this item successfully on 210a69b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24686.

avatar richard67 richard67 - test_item - 22 Apr 2019 - Tested successfully
avatar Quy
Quy - comment - 22 Apr 2019

I have tested this item successfully on 210a69b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24686.

avatar Quy Quy - change - 22 Apr 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 22 Apr 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24686.

avatar Quy Quy - test_item - 22 Apr 2019 - Tested successfully
avatar wilsonge wilsonge - close - 22 Apr 2019
avatar wilsonge wilsonge - merge - 22 Apr 2019
avatar wilsonge wilsonge - change - 22 Apr 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-22 22:04:39
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 22 Apr 2019

Thanks!

avatar brianteeman
brianteeman - comment - 22 Apr 2019

Thanks

Add a Comment

Login with GitHub to post a comment