Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24675] - [4.0] Contact - nullable datetime fields

? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
22 Apr 2019

Pull Request for Issue #16788 ....same as #21901 for modules

Summary of Changes

some datetime fields should be nullable as default

  • publish_up
  • publish_down
  • checked_out_time

Testing Instructions

test com_contacts

Expected result

contacts should works as before

avatar alikon alikon - open - 22 Apr 2019
avatar alikon alikon - change - 22 Apr 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2019
Category ⇒ Administration com_contact Front End SQL Installation Postgresql
avatar alikon alikon - change - 22 Apr 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2019
Category Administration com_contact Front End SQL Installation Postgresql ⇒ SQL Administration com_admin com_contact Front End Installation Postgresql
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Apr 2019
Title
…
[4.0][com_contact] nullable datetime fields
[4.0] Contact - nullable datetime fields
avatar franz-wohlkoenig franz-wohlkoenig - edited - 22 Apr 2019
avatar alikon alikon - change - 22 Apr 2019
The description was changed
avatar alikon alikon - edited - 22 Apr 2019
44b90c5 22 Apr 2019 avatar alikon cs
avatar wilsonge
wilsonge - comment - 22 Apr 2019

Open question (can see it both ways). Should modified date by nullable or should enforce it being date time (modified date is the created date on creation).

avatar alikon
alikon - comment - 23 Apr 2019

yes, to me too, we need to take a decision and make it consistently across the cms

avatar twister65
twister65 - comment - 5 May 2019

I have tested this item ✅ successfully on 44b90c5

with MySQL and PostgreSQL.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24675.

avatar twister65 twister65 - test_item - 5 May 2019 - Tested successfully
avatar wilsonge
wilsonge - comment - 5 May 2019

Unless anyone feels strongly I'd rather have this set all the time. So modified date is always set (to the created date time when the article is created)

avatar alikon alikon - change - 7 May 2019
The description was changed
avatar alikon alikon - edited - 7 May 2019
avatar alikon
alikon - comment - 7 May 2019

ok modified field is not null now

p.s.
i hope prepared statement should be room for a new pr

avatar wilsonge
wilsonge - comment - 7 May 2019

There's no queries here that require prepared statements. This looks fine. Just needs some tests creating and updating contacts

avatar alikon
alikon - comment - 8 May 2019

are you sure ?
just for example components/com_contact/Model/CategoryModel.php is full of places where we can use prepared statements

joomla-cms/components/com_contact/Model/CategoryModel.php

Line 193 in c5ae141

$query->where('(a.name LIKE ' . $search . ')');

joomla-cms/components/com_contact/Model/CategoryModel.php

Line 170 in c5ae141

$query->where('a.published = ' . (int) $state);

avatar Quy
Quy - comment - 15 May 2019

I have tested this item ✅ successfully on 456218b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24675.

avatar Quy Quy - change - 15 May 2019
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 15 May 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24675.

avatar Quy
Quy - comment - 15 May 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24675.

avatar Quy Quy - test_item - 15 May 2019 - Tested successfully
avatar wilsonge wilsonge - change - 16 May 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-05-16 16:08:29
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 16 May 2019
avatar wilsonge wilsonge - merge - 16 May 2019
avatar wilsonge
wilsonge - comment - 16 May 2019

Thanks!

Add a Comment

Login with GitHub to post a comment