[#24672] - [4.0] Module 'Articles - Newsflash' - exclude current article
- Fixed in Code Base
- 15 Jul 2019
- Medium
- Build: 4.0-dev
- # 24672
- Diff
- pe7er:mod_articles_news-exclude-current-article
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR adds in the Module Articles - Newsflash (mod_articles_news) an option exclude the current article to filter the current article from displaying in the newsflash module..
It's PR #23575 "Exclude current article" re-done for Joomla 4.
Summary of Changes
The Module Articles - Newsflash can display the same article as the article currently displayed on the page.
- This PR adds an option in the Latest News Module to exclude the current article.
- The option is OFF by default (so the current behavior before installing the patch is default)
- It also checks for com_content being active to prevent that other components that use an "id" might interfere with the Latest News Module output.
Testing Instructions
- Create a Module Articles - Newsflash, choose Category :Blog", assign the module to position "sidebar-right" and assign the module to display "On all pages".
- Go to a page that displays an article, for example index.php/blog/3-welcome-to-your-blog
- Refresh the page a couple of times to see that the Newsflash Module might display the same article text.
Expected result
Before installing this PR, the following options are available:
After installing this PR, there's a new option available: "Exclude current Article" that is set to "No" by default.
After configuring the "Exclude current Article" to "Yes", the module should not display the same article anymore.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings Modules Front End |
| Labels |
Added:
?
?
|
||
In certain conditions (specific category with only one item set to not display), the module will display its title without any articles.
EDIT: I guess to take care of in another patch.
Thanks for your improvements @SharkyKZ
@infograf768 Thanks, you are right. I might write another patch for that...
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24672.
I have tested this item
Great addition, thanks pe7er!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24672.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-15 08:05:10 |
| Closed_By | ⇒ | wilsonge |
Nice touch! Thanks!
Thanks for your improvements @brianteeman and @HLeithner
I've added them to this PR, and updated it also with the 4.0-dev branch