I have tested this item ✅ successfully on ac6b7ec

I have tested this item ✅ successfully on ac6b7ec

btw: @Tchangue created a similar PR: [4.0] Implementation of feature 'filter menu items by component' #21358

@pe7er closing #21358?

Yes close #21358 as it has clearly been abandoned

I have tested this item ✅ successfully on 43bb5c1

COM_MENUS_FILTER_COMPONENT_LABEL ini string missing.

I have tested this item ✅ successfully on f57ee0e

I have tested this item ✅ successfully on f57ee0e

COM_MENUS_FILTER_COMPONENT_LABEL ini string missing.

No it's not - the string didn't need to be added to this PR as it already existed.

Hmm, I can't find the string "COM_MENUS_FILTER_COMPONENT_LABEL" in any language file.

When searching for "- Select Component -", I find:

administrator\language\en-GB\en-GB.com_menus.ini:COM_MENUS_OPTION_SELECT_COMPONENT="- Select Component -"
administrator\language\en-GB\en-GB.com_users.ini:COM_USERS_OPTION_SELECT_COMPONENT="- Select Component -"

I have tested this item 🔴 unsuccessfully on f57ee0e

oops - my apologies. The label is indeed missing. I need more coffee

Same for me, more coffee ;-)

But why did everything look ok then when teesting it?

I have not tested this item.

I have not tested this item.

@richard67 View the source. The label is only visible for screen readers

@brianteeman And what would be the right change? Add the missing text "COM_MENUS_FILTER_COMPONENT_LABEL" to the language file? Or use another already existing text with the same content, i.e. "COM_MENUS_OPTION_SELECT_COMPONENT"?

just compare with the other similar filters label in the ini file, i.e value should be “Component” if I do not mistake.

I've made the suggested corrections.
Thank you all for the corrections and for testing!

I have tested this item ✅ successfully on 7c6176b

@brianteeman can you please retest?

I have tested this item ✅ successfully on 6bad408

@richard67 can you please retest?

I have tested this item ✅ successfully on 6bad408

RTC

Thanks for testing @sanderpotjer @alikon

@franz-wohlkoenig Any reason why this is not merged? Has 2 good tests, has RTC, drone and appveyor failures seem not to be related to this PR. Only thing is it needs a "rebase" (i.e. merge from 4.0-dev).

@richard67
Please ping @wilsonge when you want to get attention for 4.0 merging.

@wilsonge Any reason why this is not merged? Has 2 good tests, has RTC, drone and appveyor failures seem not to be related to this PR. Only problem is that "rebase" merge commits kill the test results in the issue tracker. Bul last "rebase" was clean, so test results are still valid.

Looks like we have an issue with drone. Informed maintainers.

@infograf768 Thanks, and thanks for helping me with pinging the right people.

@richard67 mergin j3 is @HLeithner j4 @wilsonge. i'm only managing at a low level ;-)

@franz-wohlkoenig Yes, JM meanwhile englighted me that I was pinging the wrong people.

@pe7er I have removed the RTC because I am failing to make this work.

The component filter works fine for me on the All Menu Items but when I go to the Main menu, the filter won't be applied nor will it stick as selected.

This works:

This does not work:

As you can see my selection is not there.

Another issue is, when I do select a filter on the All Menu Items and I go to Main Menu, the filter cannot be reset. The screen will be stuck to this:

Finally, I am missing this code in the populateState function:

$componentName = $this->getUserStateFromRequest($this->context . '.filter.componentName', 'filter_componentName');
		$this->setState('filter.componentName', $componentName);

@roland-d RTC is set.

I have tested this item 🔴 unsuccessfully on bb364f8

The filter is not working on all pages. See my comment.

Testing now

@franz-wohlkoenig It was the bot, I now marked my test as unsuccessful, hopefully that will stop it :)

I am powerless to the bot 😄

Although it should not mark it RTC when there is a failed test.

Agree with @roland-d findings. Same errors here.

back to pending

back to pending

@roland-d I haven't tested it as I am still traveling but won't namespacing the XML type cause issues with the way that custom elements are used?

It is not about the file itself but just the field name. Perhaps I should have used the word camel case instead of namespace as that seems to be a loaded word 😜

I have tested this item ✅ successfully on bb364f8

Able to select the menu from all menu & main menu section as per component selection Also able to reset the filters.

I have tested this item 🔴 unsuccessfully on bb364f8

The result was not quite negative, because in the test installation on joomlapbf.com no component was found connected to the menu data - so there could not be displayed a data list of components to filter. I just saw a void input field.

I have tested this item 🔴 unsuccessfully on bb364f8

I have tested this item ✅ successfully on bb364f8

works like subscriped

I have tested this item 🔴 unsuccessfully on bb364f8

tested unsuccessfully, 5th field is not a dropdown, but a text input field

I have tested this item 🔴 unsuccessfully on bb364f8

For me, only a text box appears

Printscreen

Printscreen

Setting Value
PHP Built On Linux server2.adiheutschi.ch 3.10.0-962.3.2.lve1.5.24.9.el7.x86_64 #1 SMP Wed Feb 13 08:24:50 EST 2019 x86_64
Database Type mysql
Database Version 10.2.27-MariaDB
Database Collation latin1_swedish_ci
Database Connection Collation utf8mb4_general_ci
PHP Version 7.3.10
Web Server LiteSpeed
WebServer to PHP Interface litespeed
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.120 Safari/537.36

I have tested this item 🔴 unsuccessfully on bb364f8

It does not work. It adds a textfield with no value instead of a dropdown.

PHP Version 7.3.8
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Does not work with "Contacts". Needs the component name "com_contact".

Thank you all for testing & your suggestions for improvements!

As I did not have the branch for this PR in my local git repo (hence it says "from unknown repository"),
I redid the PR with the suggested improvements.

New PR: #28832

I'm closing this one...