Sorry but this is completely wrong.

I am assuming from the code that you have added "ordering" not "filtering"

First of all this patch gives two php notices

 
Notice: Undefined variable: saveOrder in C:\htdocs\joomla-cms\administrator\components\com_banners\tmpl\clients\default.php on line 116
 
Notice: Undefined variable: saveOrder in C:\htdocs\joomla-cms\administrator\components\com_banners\tmpl\clients\default.php on line 124

It probably does that because there is no column in the database to store the ordering.

Even if you fix both of those then the main question is "why"

There is no reason to add the ability to set an order for clients. What would it allow you to do with banners that you cannot do now.

I have tested this item ? unsuccessfully on fe68691

There is no reason to add the ability to set an order for clients. What would it allow you to do with banners that you cannot do now.

@brianteeman I did this to make it consistent with other components

This still does nothing at all because there is no column in the database for ordering.

I am all for consistency but in this case it is wrong. There is no point in ordering the clients as it doesn't have any function. Only add code/features if they do something. We aslo dont have the ability to order users for the same reason - it serves no purpose

I have tested this item ? unsuccessfully on eb993bf

This PR is wrong for reasons stated by @brianteeman above:

• The banner clients table in database does not have a column for ordering, in opposite to the banners, where it makes sense.
• To add ordering for banner clients (including column in the banner_clients database table) does not provide any useful functionality and so does not make sense.

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24646.}

Closing for reasons stated above
Thanks @brianteeman @richard67 for the info

@brianteeman in the following link administrator/index.php?option=com_menus&view=items&menutype= also there is no ordering column.
Is an ordering column needed here?

Will it to anything? Is there an ordering column?

As of now there is no ordering column

I think Brian means if there is such column in the database table for this view.

Ok
How do I check this @richard67 ?

@hardik-codes With phpmyadmin or pgmyadmin, dependent on your type of database. Table is #__menu, replace #__ by your DB prefix.

But there is no need to check that. In case of menu items, ordering is a bit different.

The ordering of menu items makes only sense within one menu type. That's why the "all menu items" view does not show an ordering column, but the "menu items for a particular menu type" view shows such a column.

I think I remember there was a PR in past which made this change for the "all menu items" view.