[#24641] - [4.0] Safer extensions deletion and better post install messages insertion in schema updates
- Fixed in Code Base
- 20 Apr 2019
- Medium
- Build: 4.0-dev
- # 24641
- Diff
- richard67:4.0-schema-upd-1
- Success Hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
Pull Request for no issue.
Summary of Changes
With PR #22374 the usage of hard coded extension IDs has been removed. Thanks to @laoneo for this great work.
With that PR, statements for deleting old extensions in the schema update SQL scripts have been changed so they use the value of the element column in the extensions table to identify the record to be deleted.
Unfortunately the element value is not unique, e.g. languages have same element name for admin and site, and so there is no unique constraint which keeps any 3rd party extensions from using same element name as other extensions do. And so using the element as the only criteria in the delete statements is theoretically unsafe. Practically all works as it is now with PR #22374 , but for future schema updates using the existing ones as a template for deleting extensions it might not be granted that they are safe.
This PR here extends the where clauses in the delete statements which have been modified by PR #22374 in schema updates by additional criteria which make them as safe as possible for the particular extension type.
In addition, it changes the insert statements in schema updates for new postinstall messages to the same statements as used for new installation, so the postinstall messages have the correct extension_id = the one of files_joomla.
Testing Instructions
Code review.
@wilsonge and if possible @laoneo please review.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql |
franz-wohlkoenig
- | Title |
|
||||||
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-20 22:53:27 |
| Closed_By | ⇒ | wilsonge |
Thanks!
@franz-wohlkoenig Thanks for title update. Sorry I had forgotten the "[4.0] ".