[#24634] - [4.0] Remove module description popover
- Fixed in Code Base
- 22 Apr 2019
- Medium
- Build: 4.0-dev
- # 24634
- Diff
- brianteeman:module_popover
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
When you go to select a NEW module you have a list of all the modules with a very short 90 character truncated description.
If you hover over that description you get a popover with a short 200 character truncated description. This can result in a popover that is identical to the text it is supposed to be describing
This popover is not accessible - I doubt even most sighted users will know that it even exists as there is no visual indicator that it exists either.
The original reason for the 90 character truncation was back in the day that this was a modal and there was limited space. That is no longer true but we do need to have some form of truncation as some 3pd write essays for the description ;) so I chose the 200 character limit
This PR removes the popover and changes the displayed description to the 200 character version
I am including the screenshots as I doubt most people even knew the popover existed
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules |
| Labels |
Added:
?
|
||
Strange. It was on the right in my test setting the XML value to right
I confirm your results with the farsi language
BUT
If you set <rtl>1</rtl>
in the english language it works correctly
I am assuming there is an issue with this line of code <?php if ($document->direction != 'rtl') : ?>
but that is unrelated to this pr
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24634.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24634.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24634.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
So is there any way now of seeing the untruncated description in this view?
Same as before. In the module itself.
In the list view before we showed 90 characters and 200 on hover
Now we show 200.
Ahh sorry I missed we were only showing 200 in the popover
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-22 22:34:35 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
No problem. I was surprised at the limit in the popover too.
@Quy
Yes, the link should be on the right side.
We have the same error in 3.9.x
=> No use in this case to have a specific order for rtl.
diff --git a/administrator/components/com_modules/tmpl/select/default.php b/administrator/components/com_modules/tmpl/select/default.php
index 5157566..86a26df 100644
--- a/administrator/components/com_modules/tmpl/select/default.php
+++ b/administrator/components/com_modules/tmpl/select/default.php
@@ -25,16 +25,8 @@
<?php $name = $this->escape($item->name); ?>
<?php $desc = HTMLHelper::_('string.truncate', $this->escape(strip_tags($item->desc)), 200); ?>
-
- <?php if ($document->direction != 'rtl') : ?>
<li class="list-group-item">
<a href="<?php echo Route::_($link); ?>" class="mr-2"><strong><?php echo $name; ?></strong></a>
<small><?php echo $desc; ?></small>
</li>
- <?php else : ?>
- <li class="list-group-item">
- <small><?php echo $desc; ?></small>
- <a href="<?php echo Route::_($link); ?>" class="mr-2"><strong><?php echo $name; ?></strong></a>
- </li>
- <?php endif; ?>
<?php endforeach; ?>
</ul>
Code was OK in 2012. ;)
I know this has nothing to do with this PR. Please confirm that the link should be on the right side.
@infograf768