? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
17 Apr 2019

Pull Request for Issue #24607

Summary of Changes

always add table search path

Testing Instructions

run finder indexr from cli no warning expected

Expected result

custom fields works as before
and cli finder_indxer runs without warning

Actual result

cli finder_indexer gives warning

cc:@laoneo

avatar alikon alikon - open - 17 Apr 2019
avatar alikon alikon - change - 17 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Apr 2019
Category Administration com_fields
avatar alikon alikon - change - 17 Apr 2019
Labels Added: ?
avatar HLeithner
HLeithner - comment - 17 Apr 2019

@jjnxpct can you test this pr?

avatar jjnxpct
jjnxpct - comment - 18 Apr 2019

I tested this and the error is now gone in the cron email. Excellent.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Apr 2019

@jjnxpct please mark your test as successfully at Issue Tracker.

avatar jjnxpct
jjnxpct - comment - 18 Apr 2019

@jjnxpct please mark your test as successfully at Issue Tracker.

@franz-wohlkoenig : Not sure how to do that. Sorry, I'm getting lost in this GitHub stuff...

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Apr 2019

No Problem @jjnxpct. At https://docs.joomla.org/Testing_Joomla!_patches scroll to Subhead "Recording test results", this might be enough information. If not, please comment :-)

avatar jjnxpct
jjnxpct - comment - 18 Apr 2019

I have tested this item successfully on 4506625

Tested this on our live site where the problem occurred. After the code change the errors were gone in the cron output mail.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24630.

avatar jjnxpct jjnxpct - test_item - 18 Apr 2019 - Tested successfully
avatar jjnxpct
jjnxpct - comment - 18 Apr 2019

@franz-wohlkoenig : Thanks! Just added the successful test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24630.

avatar jjnxpct
jjnxpct - comment - 18 Apr 2019

@franz-wohlkoenig : Thanks! Just added the successful test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24630.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Apr 2019

@ReLater can you please test?

avatar jjnxpct
jjnxpct - comment - 24 May 2019

Hi! After updating Joomla the errors came back, because we tested this by changing a core file and now this file has been overriden by the Jomla update.

So I guess this means this has not been added to the Joomla release. Not sure how this works, but when can this 'fix' be expected in a next Joomla release? So we don't have to keep patching this ;-)

avatar HLeithner
HLeithner - comment - 24 May 2019

We need 2 successful tests then it can be merged in to core.

avatar jjnxpct
jjnxpct - comment - 24 May 2019

OK, thanks for letting me know. Hope someone else can test this to.

avatar Quy
Quy - comment - 24 May 2019

I have tested this item successfully on 4e4423e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24630.

avatar Quy
Quy - comment - 24 May 2019

I have tested this item successfully on 4e4423e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24630.

avatar Quy Quy - test_item - 24 May 2019 - Tested successfully
avatar Quy Quy - change - 24 May 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 24 May 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24630.

avatar Quy
Quy - comment - 24 May 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24630.

avatar HLeithner HLeithner - change - 28 May 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-28 10:35:20
Closed_By HLeithner
avatar HLeithner HLeithner - close - 28 May 2019
avatar HLeithner HLeithner - merge - 28 May 2019
avatar HLeithner
HLeithner - comment - 28 May 2019

thx

Add a Comment

Login with GitHub to post a comment