? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Apr 2019

Chosen is not accessible so we shouldnt use it unless it offers something useful.

In the tags component in the front end it is used for display #

This doesnt require or benefit from chosen so this simple PR returns it to regular and accessible list

avatar brianteeman brianteeman - open - 17 Apr 2019
avatar brianteeman brianteeman - change - 17 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Apr 2019
Category com_tags Front End
avatar zwiastunsw
zwiastunsw - comment - 17 Apr 2019

I have tested this item successfully on 7953146


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24627.

avatar zwiastunsw zwiastunsw - test_item - 17 Apr 2019 - Tested successfully
avatar Quy
Quy - comment - 17 Apr 2019

I have tested this item successfully on 7953146


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24627.

avatar Quy Quy - test_item - 17 Apr 2019 - Tested successfully
avatar Quy Quy - change - 17 Apr 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 17 Apr 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24627.

avatar franz-wohlkoenig franz-wohlkoenig - change - 18 Apr 2019
Title
[staging] Remove chosen from com_tags
Remove chosen from com_tags
avatar franz-wohlkoenig franz-wohlkoenig - edited - 18 Apr 2019
avatar brianteeman brianteeman - change - 22 Apr 2019
Labels Added: ? ?
avatar HLeithner HLeithner - change - 5 Jun 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-05 15:39:12
Closed_By HLeithner
avatar HLeithner HLeithner - close - 5 Jun 2019
avatar HLeithner HLeithner - merge - 5 Jun 2019
avatar HLeithner
HLeithner - comment - 5 Jun 2019

thx

avatar mbabker
mbabker - comment - 5 Jun 2019

LOLOLOLOL you merged this one but not the other because "it might break templates". That's hilarious.

avatar HLeithner
HLeithner - comment - 6 Jun 2019

I have no idea why you're laughing at me.

I someone wants to remove the chosen she/he can override the Frontend template. With this pr we remove a feature unexpected for the user.

In the backend you likely will not break anything if you remove chosen.

avatar brianteeman
brianteeman - comment - 6 Jun 2019

Fyi both pr were for the front end

avatar HLeithner
HLeithner - comment - 6 Jun 2019

Fyi both pr were for the front end

hmm then I mixed something up and my argument makes no sense.

avatar brianteeman
brianteeman - comment - 6 Jun 2019

my argument makes no sense.

Hence @mbabker comment

avatar HLeithner
HLeithner - comment - 6 Jun 2019

Yeah, so if this works in 3.9.7 without problems I will merge the com tags merge into 3.9.8 and hopefully make everyone happy.

Add a Comment

Login with GitHub to post a comment