[#24623] - Remove chosen from com_search
- Fixed in Code Base
- 17 Jun 2019
- Medium
- Build: staging
- # 24623
- Diff
- brianteeman:com_search_chosen
- Success Hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
Chosen is not accessible so we shouldnt use it unless it offers something useful.
In the search component in the front end there are potentially two lists Ordering and display #
Neither of these require or benefit from chosen so this simple PR returns them to regular and accessible lists
Pull Request for Issue #24469
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_search |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24623.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24623.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24623.
Whats the reason to remove this without needs? The only thing what could happen is to break sites that expect chosen.
It is removed from this page because chosen breaks accessibility and we dont need any of the added features of chosen for the select lists here.
It cannot break an existing site
franz-wohlkoenig
- | Title |
|
||||||
We don't in this view but the long standing opinion is removing this can affect ssites that were using it on other pages without the include. This was how we ended up basically rolling out chosen into every view in the backend (as well as the consistency argument). I agree with @HLeithner that this is something not to be fixed in 3.x sadly
We don't in this view but the long standing opinion is removing this can affect sites that were using it on other pages without the include.
I don't follow this logic. We are talking about a component so how it can affect other pages that are not com_search
No it doesn’t affect other pages but it does affect modules and plugins on that page
For the record I disagreed with this logic at the time. But it’s long been made standard. And especially given we should be trying to 3.x towards more support only mode in anticipation of 4.0 it doesn’t make sense to make changes like this
in which case the user can create a template override
| Labels |
Added:
?
?
|
||
I'm closing this because of the statements above not breaking user templates.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-05 15:52:18 |
| Closed_By | ⇒ | HLeithner |
Shame that accessibility doesnt matter
| Status | Closed | ⇒ | New |
| Closed_Date | 2019-06-05 15:52:18 | ⇒ | |
| Closed_By | HLeithner | ⇒ | |
| Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24623.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-17 05:31:04 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thx
thanks
I have tested this item✅ successfully on aa618b8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24623.