[#24618] - [4.0] Label for fieldset in admin login
- Closed
- 4 May 2019
- Medium
- Build: 4.0-dev
- # 24618
- Diff
- chmst:a11y-admin-mod-login-remove-fieldset
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue joomla/backend-template#112 .
Summary of Changes
(Remove Tag Fieldset. In the login form, there is no need to group the input fields.)
Add label to fieldset.
Testing Instructions
Code Review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
franz-wohlkoenig
- | Title |
|
||||||
It is a single form on a singele login screen. See also the linked issue and discussion
The frontend login screen has no fieldset. There it would make more sense as it can occur often and everywhere.
I'm against it. There is no point in saying that something doesn't make sense. Sometimes we don't see it, but it doesn't mean it doesn't make sense. The information about the group of fields is important for the users of assistive technologies.
The screen reader informs the user that it is dealing with a group of fields and reads its legend.
Just because its a single form doesnt mean that it is not a fieldset
| Labels |
Added:
?
?
|
||
| Title |
|
||||||
| Title |
|
||||||
Closing as a11y team lead is against
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-04 15:03:01 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Removed: ? |
||
Why is there no need for this to be a fieldset?
A fieldset should be used when you need to show a relationship between multiple form inputs.
Surely there is a relationship between username and password ?