NPM Resource Changed ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Apr 2019

Changes <a role="button
to <button type="button

Reported by @zwiastunsw #23737

avatar brianteeman brianteeman - open - 16 Apr 2019
avatar brianteeman brianteeman - change - 16 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Apr 2019
Category Administration com_media NPM Change
avatar Quy
Quy - comment - 16 Apr 2019

Related PR #24428

avatar brianteeman
brianteeman - comment - 16 Apr 2019

@Quy didn't see that one - which only covers one button

avatar wilsonge wilsonge - change - 16 Apr 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-16 23:10:32
Closed_By wilsonge
Labels Added: NPM Resource Changed ?
avatar wilsonge wilsonge - close - 16 Apr 2019
avatar wilsonge wilsonge - merge - 16 Apr 2019
avatar wilsonge
wilsonge - comment - 16 Apr 2019

That one is also missing the type attribute on the button he is fixing - so merging this. Thanks!

avatar Quy
Quy - comment - 16 Apr 2019

The other one also fixes the closing " in the title attribute.

avatar bahl24
bahl24 - comment - 17 Apr 2019

@wilsonge @Quy That PR is for diff bug-

Expected
Screenshot from 2019-04-17 12-59-02
Actual
Screenshot from 2019-04-17 12-56-26

I have resolved the conflicts, kindly check #24428

Add a Comment

Login with GitHub to post a comment