Feeling Lucky
?
[#24612] - [4.0] Add lock icon to login button
- Closed
- 16 Apr 2019
- Medium
- Build: 4.0-dev
- # 24612
- Diff
- hardik-codes:lock-icon
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
This PR adds lock icon to login button in the administrator login
After patch
3.x
Also in 3.x there was a lock icon
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
hardik-codes
- comment
- 16 Apr 2019
This is also under the control of the admin template team see https://github.com/joomla/backend-template so should be closed
and for future reference when you are using font icons you also need to add aria-hidden=true - search and you will find hundreds of examples
Thanks for the info
After closing this PR, should I make a PR in https://github.com/joomla/backend-template?
Quy
- comment
- 16 Apr 2019
Yes, but to the release branch.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-16 19:19:36 |
| Closed_By | ⇒ | hardik-codes | |
| Labels |
Added:
?
|
||
This is also under the control of the admin template team see https://github.com/joomla/backend-template so should be closed
and for future reference when you are using font icons you also need to add aria-hidden=true - search and you will find hundreds of examples