? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
16 Apr 2019

Pull Request for Issue # .

Summary of Changes

Changes configuration value comparison.

Testing Instructions

Make sure System - Debug plugin is enabled.

In Global Configuration disable Debug System and Debug Language options.

Enable Gzip Page Compression.

Check that GZip is enabled. This can be done in browser by checking that Joomla pages send X-Content-Encoded-By:"Joomla" header.

Expected result

GZip is enabled.

Actual result

GZip is disabled.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 16 Apr 2019
avatar SharkyKZ SharkyKZ - change - 16 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Apr 2019
Category Front End Plugins
avatar SharkyKZ SharkyKZ - change - 16 Apr 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 16 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Apr 2019
Title
[4.0][plg_system_debug] Debug settings not respected
[4.0] [plg_system_debug] Debug settings not respected
avatar franz-wohlkoenig franz-wohlkoenig - edited - 16 Apr 2019
avatar jeckodevelopment jeckodevelopment - change - 16 Apr 2019
Labels Added: ?
avatar Quy
Quy - comment - 16 Apr 2019

I have tested this item successfully on 81afe43


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24604.

avatar Quy
Quy - comment - 16 Apr 2019

I have tested this item successfully on 81afe43


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24604.

avatar Quy Quy - test_item - 16 Apr 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Title
[4.0] [plg_system_debug] Debug settings not respected
[4.0] Debug settings not respected
avatar franz-wohlkoenig franz-wohlkoenig - edited - 19 Apr 2019
avatar euismod2336 euismod2336 - test_item - 4 May 2019 - Tested successfully
avatar euismod2336 euismod2336 - test_item - 4 May 2019 - Tested successfully
avatar euismod2336 euismod2336 - test_item - 4 May 2019 - Tested successfully
avatar euismod2336 euismod2336 - test_item - 4 May 2019 - Tested successfully
avatar euismod2336
euismod2336 - comment - 4 May 2019

I have tested this item successfully on 81afe43

works as advertised, only suggestion i'd have is to do the checks earlier, because why check $db and $app if the plugin is skipped.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24604.

avatar euismod2336 euismod2336 - test_item - 4 May 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 May 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 May 2019

Status "Ready To Commit".

avatar wilsonge wilsonge - change - 4 May 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-05-04 17:29:36
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 4 May 2019
avatar wilsonge wilsonge - merge - 4 May 2019
avatar wilsonge
wilsonge - comment - 4 May 2019

Thanks!

Add a Comment

Login with GitHub to post a comment