[#24583] - [4.0] Module position no more empty when coming from CPanel
- Closed
- 23 Apr 2019
- Medium
- Build: 4.0-dev
- # 24583
- Diff
- infograf768:4.0_modules_cpanel_userstate
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #24575
Summary of Changes
Forcing userstate to administrator modules
Testing Instructions
Load Site Modules Manager to be sure userstate is set to site modules
Switch to Control Panel
Edit a module through the cog
Before patch
The module position is empty
After patch
It is now correctly using cpanel position
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
?
|
||
Solved conflicts.
One more tester.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24583.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24583.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
This is not the right approach, IMO. The layout should not be setting user state. This way admin filter is forced whenever a page containing a module with this layout is visited.
@SharkyKZ
There are 2 possible solutions:
-
Check if the position is
cpaneland set userstate in the layout.
This would work for all admin modules in the cpanel position and only for these -
The only other solution I see is to add in EACH admin module helper the code
Factory::getApplication()->setUserState('com_modules.modules.client_id', 1);
What do you propose?
One option is to get client_id from form data in the field here:
$clientId = $this->form->getValue('client_id', '', Factory::getApplication()->getUserState('com_modules.modules.client_id', 0));
Other option would be to add client_id to URL and have controller set the user state based on that.
Please make the PR yourself as I do not understand what you propose.
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-23 07:55:46 |
| Closed_By | ⇒ | infograf768 |
I have tested this item✅ successfully on a0846e4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24583.