? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
11 Apr 2019

This simple PR updates the view of the module to J4 standards

Before

image

After

image

avatar brianteeman brianteeman - open - 11 Apr 2019
avatar brianteeman brianteeman - change - 11 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2019
Category Administration Language & Strings Modules
avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Apr 2019
Category Administration Language & Strings Modules Administration Modules
avatar chmst
chmst - comment - 12 Apr 2019

I have tested this item successfully on 0638b4a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24563.

avatar chmst chmst - test_item - 12 Apr 2019 - Tested successfully
avatar alikon
alikon - comment - 12 Apr 2019

I have tested this item successfully on 0638b4a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24563.

avatar alikon alikon - test_item - 12 Apr 2019 - Tested successfully
avatar Quy Quy - change - 12 Apr 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Apr 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24563.

avatar infograf768 infograf768 - change - 13 Apr 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2019
Category Administration Modules Administration Language & Strings Modules
avatar infograf768
infograf768 - comment - 13 Apr 2019

OK here.
Note: The helper should be namespaced and moved to a Helper folder. But I guess this will have to be done when com_actionlogs will be namespaced.

avatar brianteeman
brianteeman - comment - 13 Apr 2019

Yes I deliberately left that for another pr

avatar alikon
alikon - comment - 13 Apr 2019

some works on namespacing actionlogs has been already done in 3.9.x where x > 0 ?

avatar infograf768
infograf768 - comment - 13 Apr 2019

If nobody on it, I am finishing a similar PR for mod_privacy_dashboard

avatar infograf768
infograf768 - comment - 13 Apr 2019

Please test #24573

avatar wilsonge wilsonge - change - 14 Apr 2019
Labels Added: ? ?
avatar wilsonge wilsonge - change - 14 Apr 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-14 23:00:12
Closed_By wilsonge
avatar wilsonge wilsonge - close - 14 Apr 2019
avatar wilsonge wilsonge - merge - 14 Apr 2019
avatar wilsonge
wilsonge - comment - 14 Apr 2019

Thanks!

avatar brianteeman
brianteeman - comment - 15 Apr 2019

Thanks

Add a Comment

Login with GitHub to post a comment