Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24559] - [4.0] Resolve B/C break in BaseDatabaseModel

J4 Issue ?
avatar wilsonge
wilsonge
11 Apr 2019

The LeagcyModelLoaderTrait is having unexpected behaviour in J4. The static variable used to load the classes is unfortunately initialised per class. This means changing BaseDatabaseModel::getInstance()/JModelLegacy::getInstance() to BaseModel::getInstance() - this is not an intended b/c break. Options are:

  • Move the trait to BaseDatabaseModel from BaseModel
  • Rework the static variable to one in the trait. However this will allow 3rd parties to override it which isn't intended.

This has been an issue I've had to manually patch in the action logs and privacy components (e.g. 494a567), so is definitely a real thing for components migrating from J3 to J4

avatar wilsonge wilsonge - open - 11 Apr 2019
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 11 Apr 2019
avatar wilsonge wilsonge - change - 11 Apr 2019
Labels Added: ?
avatar wilsonge wilsonge - labeled - 11 Apr 2019
avatar wilsonge wilsonge - change - 11 Apr 2019
Labels Added: J4 Issue
avatar wilsonge wilsonge - labeled - 11 Apr 2019
avatar wilsonge wilsonge - change - 11 Apr 2019
The description was changed
avatar wilsonge wilsonge - edited - 11 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Apr 2019
Labels Removed: ?
avatar franz-wohlkoenig franz-wohlkoenig - unlabeled - 12 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Apr 2019
Status New ⇒ Discussion
avatar wilsonge wilsonge - change - 12 Apr 2019
Labels Added: ?
avatar wilsonge wilsonge - labeled - 12 Apr 2019
avatar Quy Quy - change - 1 Oct 2019
Labels Added: ? ? ?
Removed: ?
avatar Quy Quy - change - 1 Oct 2019
Labels Added: ? ? ?
Removed: ?
avatar Quy Quy - labeled - 1 Oct 2019
avatar Quy Quy - labeled - 1 Oct 2019
avatar alikon alikon - change - 24 Jan 2020
Labels Removed: ? ?
avatar alikon alikon - unlabeled - 24 Jan 2020
avatar alikon alikon - unlabeled - 24 Jan 2020
avatar wilsonge wilsonge - change - 28 Jan 2020
Labels Added: ?
avatar wilsonge wilsonge - labeled - 28 Jan 2020
avatar jwaisner jwaisner - change - 17 Feb 2020
Priority Medium ⇒ Urgent
avatar joomla-cms-bot joomla-cms-bot - change - 17 Feb 2020
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - unlabeled - 17 Feb 2020
avatar jwaisner
jwaisner - comment - 17 Feb 2020

Increasing priority as per guidelines for beta-blockers.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24559.

avatar jwaisner jwaisner - change - 17 Feb 2020
Labels Added: ?
avatar jwaisner jwaisner - labeled - 17 Feb 2020
avatar jwaisner jwaisner - change - 18 Feb 2020
Build staging ⇒ 4.0dev
avatar joomla-cms-bot joomla-cms-bot - change - 18 Feb 2020
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - unlabeled - 18 Feb 2020
avatar jwaisner jwaisner - change - 18 Feb 2020
Labels Added: ?
avatar jwaisner jwaisner - labeled - 18 Feb 2020
avatar jwaisner jwaisner - change - 18 Feb 2020
Status Discussion ⇒ Confirmed
avatar wilsonge
wilsonge - comment - 20 Feb 2020

Agreed in meeting to remove methods + properties from the trait

avatar rdeutz rdeutz - change - 20 Feb 2020
Status Confirmed ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-02-20 22:08:43
Closed_By ⇒ rdeutz
Labels Added: ?
Removed: ?
avatar rdeutz
rdeutz - comment - 20 Feb 2020

Closing because we have a PR #27998

avatar rdeutz rdeutz - close - 20 Feb 2020
avatar rdeutz rdeutz - change - 20 Feb 2020
Labels Removed: ? ?
avatar rdeutz rdeutz - unlabeled - 20 Feb 2020
avatar rdeutz rdeutz - unlabeled - 20 Feb 2020

Add a Comment

Login with GitHub to post a comment