[#24553] - [4.0] Correcting broken Overrides Manager
- Fixed in Code Base
- 11 Apr 2019
- Medium
- Build: 4.0-dev
- # 24553
- Diff
- infograf768:4.0_overrides_manager
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
The filters are not displayed in 4.0, preventing a normal use of the Manager
This PR corrects the Overrrides Manager to get the same display as in 3.x
Testing Instructions
Before patch. No language client filters. Filter Options also broken.
Patch then make sure that 2 files are deleted:
-
administrator/components/com_languages/Field/Languageclient.php
it is replaced in the patch by
administrator/components/com_languages/Field/LanguageclientField.php -
administrator/components/com_languages/layouts/joomla/searchtools/default/bar.phphas to be DELETED.
We now use the new file
administrator/components/com_languages/layouts/joomla/searchtools/default.php
EDIT: for those using patchtester, it will work ok if bar.php is not deleted.
Before patch
No filters to choose from in order to create overrides.
Filter Options as well as column ordering and limit box are broken.
After patch
Filters are back.
Note: this patch does not prevent, for the Ajax specialists, to improve the whole stuff.
It just corrects the functionality as it works in 3.x
See discussion #22107 , speciffically posts by @coolcat-creations
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_languages Language & Strings |
| Labels |
Added:
J4 Issue
?
?
|
||
Try to create a new Language Override got:
System information
| Setting | Value |
|---|---|
| PHP Built On | Linux lamp122.cloudaccess.net 3.10.0-962.3.2.lve1.5.24.7.el6h.x86_64 nr.1 SMP Mon Dec 17 12:02:35 EST 2018 x86_64 |
| Database Type | mysql |
| Database Version | 5.7.24-cll-lve |
| Database Collation | utf8_general_ci |
| Database Connection Collation | utf8_general_ci |
| PHP Version | 7.1.26 |
| Web Server | Apache |
| WebServer to PHP Interface | cgi-fcgi |
| Joomla! Version | Latest Nightly Build Update from Joomla! 4.0.0-alpha8-dev Development [ Amani ] 9-March-2019 13:41 GMT |
| User Agent | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:66.0) Gecko/20100101 Firefox/66.0 |
The file concerned by your error has been already corrected in this patch. There is no more JFactory in the file:
~/administrator/components/com_languages/View/Override/HtmlView.php
So first apply Patch, then create new Override?
So first apply Patch, then create new Override?
yes, you can't otherwise
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24553.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24553.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-11 10:11:03 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Note: npm not necessary.