[#24550] - [4.0] Add tag filter to category list
- Closed
- 26 Aug 2020
- Medium
- Build: 4.0-dev
- # 24550
- Diff
- stutteringp0et:patch-11
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
#24398 requested the tag filter option available in Category Blog be made available in Category List. This simple XML change is the only thing necessary to accomplish this request.
Pull Request for Issue # .
Summary of Changes
Simple XML change to the Category List (default.xml) enables tag filtering
Testing Instructions
Create several articles in the same category using various tags
Create several Category List menu items for the category using the various tags used previously
Expected result
Tag filtered Category List
Actual result
Works for me
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Title |
|
||||||
| Title |
|
||||||
@test Filters seems to works fine using this PR stutteringp0et#1
I have tested this item
This needs a fix as suggested by merging PR of @fastslack "Fix SQL issue for ajax search" into this PR.
Also: When a tag is removed the "old" tag is still in the Joomla state, so only in a new session the user will see all articles for a category again. Would be nice to make sure that if no tag is selected this is directly forced in the state.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24550.
I can find no PR titled "Fix SQL issue for ajax search" and none of @fastslack 's PR's match that description.
Is there a # I can look up?
| Labels |
Added:
?
|
||
| Category | Front End com_content | ⇒ | Front End com_content Libraries |
How do I resolve the conflicts?
| Labels |
Added:
Conflicting Files
|
||
Thank you for pointing me in the right direction @franz-wohlkoenig
This needs, what - 2 more human tests?
This needs, what - 2 more human tests?
Yes. After 2 successfully Tests Release Lead decide if merge.
@fastslack do you mind testing again?
@rytechsites this is on your request, can you test?
I would be interested in testing this. Can someone tell me the exact 'joomla 4' version I should download that includes this fix? I'm sorry for my ignorance, I haven't tested in this way before.
Thanks again for getting this done!
-- Laura
i think you should download & install the nigthly build from here https://developer.joomla.org/nightly-builds.html which doesn't include this pr and then install the com_patchtester a guide for using patchtester https://docs.joomla.org/Component_Patchtester_for_Testers
Thank you, this is excellent! I should be able to test in the next day or
so!
-- Laura
On Tue, Jul 23, 2019 at 1:07 PM Nicola Galgano notifications@github.com
wrote:
i think you should download & install the nigthly build from here
https://developer.joomla.org/nightly-builds.html which doesn't include
this pr and then install the com_patchtester a guide for using patchtester
https://docs.joomla.org/Component_Patchtester_for_Testers—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/24550?email_source=notifications&email_token=AEIIWYFC4OY6PRT7Q6G7LPDQA43FXA5CNFSM4HFAPRHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2TZLMY#issuecomment-514299315,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEIIWYBZ6NIYYBBXAEMRME3QA43FXANCNFSM4HFAPRHA
.
--
www.RytechSites.com http://www.rytechsites.com/
Dynamic Websites for your company!
Trainer with www.lynda.com http://www.Lynda.com
Member www.JoomlaUsersNJ.com
Proud Board Member of: www.aecdc.org
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24550.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24550.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24550.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24550.
Since this is a missing xml field I would accept this als backport for j3 if someone is interested to do this.
@stutteringp0et This has been awhile but I think the failed tests come from the file conflict. Could you fix the conflict please?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-26 15:24:29 |
| Closed_By | ⇒ | Quy |
@rytechsites please test as Opener of #24398. how to test: https://docs.joomla.org/Testing_Joomla!_patches